[PATCH] Fixed: Part of output missing during RAID creation

ICAgIEZpeGVkOiBQYXJ0IG9mIG91dHB1dCBtaXNzaW5nIGR1cmluZyBSQUlE IGNyZWF0aW9uCiAg
ICAKICAgIEhhdmluZyBhIGNvbnRhaW5lciBjcmVhdGVkIGNvbnNpc3Rpbmcg b2YgMiBkaXNrcywg
d2hlbiBvbmUgdHJpZWQgdG8gY3JlYXRlCiAgICB0d28gdm9sdW1lcyBvZiB0 aGUgc2FtZSBSQUlE
IGxldmVsLCBhZnRlciBhdHRlbXB0IG9mIGNyZWF0aW5nIHRoZSBzZWNvbmQK ICAgIG9uZSwgcGFy
dCBvZiB0aGUgbWVzc2FnZSB3YXMgbWlzc2luZzoKICAgIAogICAgI21kYWRt IC1DIC9kZXYvbWQv
aW1zbTAgLWFtZCAtZSBpbXNtIC1uIDIgL2Rldi9zZGEgL2Rldi9zZGIgLVIK ICAgICNtZGFkbSAt
QyAvZGV2L21kL015Vm9sdW1lMSAtYW1kIC1sMCAtYzEyOCAtbiAyIC9kZXYv c2RhIC9kZXYvc2Ri
IC1SCiAgICAjbWRhZG0gLUMgL2Rldi9tZC9NeVZvbHVtZTIgLWFtZCAtbDAg LWMxMjggLW4gMiAv
ZGV2L3NkYSAvZGV2L3NkYiAtUgogICAgCiAgICBBZnRlciBjYWxsaW5nIHRo ZSBsYXN0IGNvbW1h
bmQsIHRoZSBvdXRwdXQgd2FzOgogICAgbWRhZG06IGNyZWF0ZSBhYm9ydGVk CiAgICAKICAgIE5v
dyBpdCdzOgogICAgbWRhZG06IGRldmljZSAvZGV2L3NkYiBub3Qgc3VpdGFi bGUgZm9yIHRoaXMg
c3R5bGUgb2YgYXJyYXkKICAgIG1kYWRtOiBjcmVhdGUgYWJvcnRlZAogICAg CiAgICBSZW1vdmVk
IGEgcGllY2Ugb2YgY29kZSBhdHRlbXB0aW5nIHRvIGV4Y2x1c2l2ZWx5IG9w ZW4gYSBmaWxlIGp1
c3QgdG8KICAgIGNoZWNrIHdoZXRoZXIgaXQncyBwb3NzaWJsZS4gVGhlIHJl YXNvbiBpcyB0aGF0
IHRoYXQgY2hlY2sgd2FzIHBlcmZvcm1lZAogICAgd2hlbiBpdCB3YXMgYWxy ZWFkeSBkZXRlcm1p
bmVkIHRoYXQgYSB2b2x1bWUgY2Fubm90IGJlIGNyZWF0ZWQuIFB1dAogICAg YSBwcm9tcHQgYWJv
dXQgdGhlIGRldmljZSBub3QgYmVpbmcgc3VpdGFibGUgaW5zdGVhZC4KICAg IAogICAgU2lnbmVk
LW9mZi1ieTogTHVrYXN6IE9ybG93c2tpIDxsdWthc3oub3Jsb3dza2lAaW50 ZWwuY29tPgoKLS0t
CgpMdWthc3ogT3Jsb3dza2kgKDEpOgogICAgICBGaXhlZDogUGFydCBvZiBv dXRwdXQgbWlzc2lu
ZyBkdXJpbmcgUkFJRCBjcmVhdGlvbgoKCiBDcmVhdGUuYyB8ICAgMTIgKysr Ky0tLS0tLS0tCiAx
IGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMo LSkKCi0tIApTaWdu
YXR1cmUKLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tCkludGVsIFRlY2hub2xvZ3kgUG9sYW5kIHNw LiB6IG8uby4KeiBz
aWVkemliYSB3IEdkYW5za3UKdWwuIFNsb3dhY2tpZWdvIDE3Mwo4MC0yOTgg R2RhbnNrCgpTYWQg
UmVqb25vd3kgR2RhbnNrIFBvbG5vYyB3IEdkYW5za3UsIApWSUkgV3lkemlh bCBHb3Nwb2RhcmN6
eSBLcmFqb3dlZ28gUmVqZXN0cnUgU2Fkb3dlZ28sIApudW1lciBLUlMgMTAx ODgyCgpOSVAgOTU3
LTA3LTUyLTMxNgpLYXBpdGFsIHpha2xhZG93eSAyMDAuMDAwIHpsCgpUaGlz IGUtbWFpbCBhbmQg
YW55IGF0dGFjaG1lbnRzIG1heSBjb250YWluIGNvbmZpZGVudGlhbCBtYXRl cmlhbCBmb3IKdGhl
IHNvbGUgdXNlIG9mIHRoZSBpbnRlbmRlZCByZWNpcGllbnQocykuIEFueSBy ZXZpZXcgb3IgZGlz
dHJpYnV0aW9uCmJ5IG90aGVycyBpcyBzdHJpY3RseSBwcm9oaWJpdGVkLiBJ ZiB5b3UgYXJlIG5v
dCB0aGUgaW50ZW5kZWQKcmVjaXBpZW50LCBwbGVhc2UgY29udGFjdCB0aGUg c2VuZGVyIGFuZCBk
ZWxldGUgYWxsIGNvcGllcy4K

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] Fixed: Part of output missing during RAID creation

SGF2aW5nIGEgY29udGFpbmVyIGNyZWF0ZWQgY29uc2lzdGluZyBvZiAyIGRp c2tzLCB3aGVuIG9u
ZSB0cmllZCB0byBjcmVhdGUKdHdvIHZvbHVtZXMgb2YgdGhlIHNhbWUgUkFJ RCBsZXZlbCwgYWZ0
ZXIgYXR0ZW1wdCBvZiBjcmVhdGluZyB0aGUgc2Vjb25kCm9uZSwgcGFydCBv ZiB0aGUgbWVzc2Fn
ZSB3YXMgbWlzc2luZzoKCiNtZGFkbSAtQyAvZGV2L21kL2ltc20wIC1hbWQg LWUgaW1zbSAtbiAy
IC9kZXYvc2RhIC9kZXYvc2RiIC1SCiNtZGFkbSAtQyAvZGV2L21kL015Vm9s dW1lMSAtYW1kIC1s
MCAtYzEyOCAtbiAyIC9kZXYvc2RhIC9kZXYvc2RiIC1SCiNtZGFkbSAtQyAv ZGV2L21kL015Vm9s
dW1lMiAtYW1kIC1sMCAtYzEyOCAtbiAyIC9kZXYvc2RhIC9kZXYvc2RiIC1S CgpBZnRlciBjYWxs
aW5nIHRoZSBsYXN0IGNvbW1hbmQsIHRoZSBvdXRwdXQgd2FzOgptZGFkbTog Y3JlYXRlIGFib3J0
ZWQKCk5vdyBpdCdzOgptZGFkbTogZGV2aWNlIC9kZXYvc2RiIG5vdCBzdWl0 YWJsZSBmb3IgdGhp
cyBzdHlsZSBvZiBhcnJheQptZGFkbTogY3JlYXRlIGFib3J0ZWQKClJlbW92 ZWQgYSBwaWVjZSBv
ZiBjb2RlIGF0dGVtcHRpbmcgdG8gZXhjbHVzaXZlbHkgb3BlbiBhIGZpbGUg anVzdCB0bwpjaGVj
ayB3aGV0aGVyIGl0J3MgcG9zc2libGUuIFRoZSByZWFzb24gaXMgdGhhdCB0 aGF0IGNoZWNrIHdh
cyBwZXJmb3JtZWQKd2hlbiBpdCB3YXMgYWxyZWFkeSBkZXRlcm1pbmVkIHRo YXQgYSB2b2x1bWUg
Y2Fubm90IGJlIGNyZWF0ZWQuIFB1dAphIHByb21wdCBhYm91dCB0aGUgZGV2 aWNlIG5vdCBiZWlu
ZyBzdWl0YWJsZSBpbnN0ZWFkLgoKU2lnbmVkLW9mZi1ieTogTHVrYXN6IE9y bG93c2tpIDxsdWth
c3oub3Jsb3dza2lAaW50ZWwuY29tPgotLS0KIENyZWF0ZS5jIHwgICAxMiAr KysrLS0tLS0tLS0K
IDEgZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9u cygtKQoKZGlmZiAt
LWdpdCBhL0NyZWF0ZS5jIGIvQ3JlYXRlLmMKaW5kZXggYmFhZGQ5Zi4uYjVk MzVlOCAxMDA2NDQK
LS0tIGEvQ3JlYXRlLmMKKysrIGIvQ3JlYXRlLmMKQEAgLTM0OSwxNCArMzQ5 LDEwIEBAIGludCBD
cmVhdGUoc3RydWN0IHN1cGVydHlwZSAqc3QsIGNoYXIgKm1kZGV2LAogCQkJ fQogCiAJCQlpZiAo
IXN0KSB7Ci0JCQkJaW50IGRmZCA9IG9wZW4oZG5hbWUsIE9fUkRPTkxZfE9f RVhDTCk7Ci0JCQkJ
aWYgKGRmZCA+PSAwKSB7Ci0JCQkJCWZwcmludGYoc3RkZXJyLAotCQkJCQkJ TmFtZSAiOiBkZXZp
Y2UgJXMgbm90IHN1aXRhYmxlIgotCQkJCQkJIiBmb3IgYW55IHN0eWxlIG9m IGFycmF5XG4iLAot
CQkJCQkJZG5hbWUpOwotCQkJCQljbG9zZShkZmQpOwotCQkJCX0KKwkJCQlm cHJpbnRmKHN0ZGVy
ciwKKwkJCQkJTmFtZSAiOiBkZXZpY2UgJXMgbm90IHN1aXRhYmxlIgorCQkJ CQkiIGZvciB0aGlz
IHN0eWxlIG9mIGFycmF5XG4iLAorCQkJCQlkbmFtZSk7CiAJCQkJZmFpbCA9 IDE7CiAJCQkJYnJl
YWs7CiAJCQl9CgotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KSW50ZWwgVGVjaG5vbG9neSBQb2xh bmQgc3AuIHogby5v
Lgp6IHNpZWR6aWJhIHcgR2RhbnNrdQp1bC4gU2xvd2Fja2llZ28gMTczCjgw LTI5OCBHZGFuc2sK
ClNhZCBSZWpvbm93eSBHZGFuc2sgUG9sbm9jIHcgR2RhbnNrdSwgClZJSSBX eWR6aWFsIEdvc3Bv
ZGFyY3p5IEtyYWpvd2VnbyBSZWplc3RydSBTYWRvd2VnbywgCm51bWVyIEtS UyAxMDE4ODIKCk5J
UCA5NTctMDctNTItMzE2CkthcGl0YWwgemFrbGFkb3d5IDIwMC4wMDAgemwK ClRoaXMgZS1tYWls
IGFuZCBhbnkgYXR0YWNobWVudHMgbWF5IGNvbnRhaW4gY29uZmlkZW50aWFs IG1hdGVyaWFsIGZv
cgp0aGUgc29sZSB1c2Ugb2YgdGhlIGludGVuZGVkIHJlY2lwaWVudChzKS4g QW55IHJldmlldyBv
ciBkaXN0cmlidXRpb24KYnkgb3RoZXJzIGlzIHN0cmljdGx5IHByb2hpYml0 ZWQuIElmIHlvdSBh
cmUgbm90IHRoZSBpbnRlbmRlZApyZWNpcGllbnQsIHBsZWFzZSBjb250YWN0 IHRoZSBzZW5kZXIg
YW5kIGRlbGV0ZSBhbGwgY29waWVzLgo=

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Fixed: Part of output missing during RAID creation

--Sig_/SrM+du3TX3Za_L5dNiGJN3K
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Tue, 20 Sep 2011 17:21:27 +0200 Lukasz Orlowski
wrote:

> Having a container created consisting of 2 disks, when one tried to create
> two volumes of the same RAID level, after attempt of creating the second
> one, part of the message was missing:
>=20
> #mdadm -C /dev/md/imsm0 -amd -e imsm -n 2 /dev/sda /dev/sdb -R
> #mdadm -C /dev/md/MyVolume1 -amd -l0 -c128 -n 2 /dev/sda /dev/sdb -R
> #mdadm -C /dev/md/MyVolume2 -amd -l0 -c128 -n 2 /dev/sda /dev/sdb -R
>=20
> After calling the last command, the output was:
> mdadm: create aborted
>=20
> Now it's:
> mdadm: device /dev/sdb not suitable for this style of array
> mdadm: create aborted
>=20
> Removed a piece of code attempting to exclusively open a file just to
> check whether it's possible. The reason is that that check was performed
> when it was already determined that a volume cannot be created. Put
> a prompt about the device not being suitable instead.
>=20
> Signed-off-by: Lukasz Orlowski
> ---
> Create.c | 12 ++++--------
> 1 files changed, 4 insertions(+), 8 deletions(-)
>=20
> diff --git a/Create.c b/Create.c
> index baadd9f..b5d35e8 100644
> --- a/Create.c
> +++ b/Create.c
> @@ -349,14 +349,10 @@ int Create(struct supertype *st, char *mddev,
> }
> =20
> if (!st) {
> - int dfd =3D open(dname, O_RDONLY|O_EXCL);
> - if (dfd >=3D 0) {
> - fprintf(stderr,
> - Name ": device %s not suitable"
> - " for any style of array\n",
> - dname);
> - close(dfd);
> - }
> + fprintf(stderr,
> + Name ": device %s not suitable"
> + " for this style of array\n",
> + dname);
> fail =3D 1;
> break;
> }
>=20

I think I get what you are trying to do here, but I don't like the approach.
The problem is that validate_geometry should be reporting errors but it is
told not to.

I have just committed the following patch. See if it helps.

NeilBrown


=46rom ecbd9e8160e9de9cc28ad869d303506b1dc69715 Mon Sep 17 00:00:00 2001
From: NeilBrown
Date: Wed, 21 Sep 2011 14:39:01 +1000
Subject: [PATCH] Create: improve messages from validate_geometry.

When validate_geometry finds that we haven't committed to
a metadata yet and that the subdev is a member of 'our'
container, it needs to report any errors it finds as Create()
cannot report them effectively.

So make a slight change to the semantics of the 'verbose' flag
and allow validate_geometry to report if it printed any error
messages.

Signed-off-by: NeilBrown

diff --git a/Create.c b/Create.c
index 8d88aa1..79564c5 100644
--- a/Create.c
+++ b/Create.c
@@ -332,15 +332,25 @@ int Create(struct supertype *st, char *mddev,
char *name =3D "default";
for(i=3D0; !st && superlist[i]; i++) {
st =3D superlist[i]->match_metadata_desc(name);
+ if (!st)
+ continue;
if (do_default_layout)
layout =3D default_layout(st, level, verbose);
- if (st && !st->ss->validate_geometry
- (st, level, layout, raiddisks,
- &chunk, size*2, dname, &freesize,
- verbose > 0)) {
+ switch (st->ss->validate_geometry(
+ st, level, layout, raiddisks,
+ &chunk, size*2, dname, &freesize,
+ verbose > 0)) {
+ case -1: /* Not valid, message printed, and not
+ * worth checking any further */
+ exit(2);
+ break;
+ case 0: /* Geometry not valid */
free(st);
st =3D NULL;
chunk =3D do_default_chunk ? UnSet : chunk;
+ break;
+ case 1: /* All happy */
+ break;
}
}
=20
diff --git a/mdadm.h b/mdadm.h
index bd3063b..8dd37d9 100644
--- a/mdadm.h
+++ b/mdadm.h
@@ -702,6 +702,12 @@ extern struct superswitch {
* inter-device dependencies, it should record sufficient details
* so these can be validated.
* Both 'size' and '*freesize' are in sectors. chunk is KiB.
+ * Return value is:
+ * 1: everything is OK
+ * 0: not OK for some reason - if 'verbose', then error was reported.
+ * -1: st->sb was NULL, 'subdev' is a member of a container of this
+ * types, but array is not acceptable for some reason
+ * message was reported even if verbose is 0.
*/
int (*validate_geometry)(struct supertype *st, int level, int layout,
int raiddisks,
diff --git a/super-intel.c b/super-intel.c
index e57d18f..e9d9af8 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -5369,7 +5369,8 @@ static int validate_geometry_imsm(struct supertype *s=
t, int level, int layout,
return validate_geometry_imsm_volume(st, level, layout,
raiddisks, chunk,
size, dev,
- freesize, verbose);
+ freesize, 1)
+ ? 1 : -1;
}
}
=20


--Sig_/SrM+du3TX3Za_L5dNiGJN3K
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)

iD8DBQFOeWquG5fc6gV+Wb0RAjTKAKDKMf88Pcp1GZzzJez2gT4nsNsAiwCg wPig
SE7FL/AJ2oerj3tho7hGyJo=
=I+gj
-----END PGP SIGNATURE-----

--Sig_/SrM+du3TX3Za_L5dNiGJN3K--
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html