[PATCH][RESUBMIT] mysql_db_quote + UTF8 flagged strings

am 25.08.2004 12:47:27 von cubic

--------------010008020703000809000806
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hello.
I didn't get any feedback on patch, but it is still major problem for
users of UTF8 strings cause we have to workaround DBD::mysql behavior.

Attached patch fix problems for users of perl5.8.x when somebody try
quote strings with UTF8 flag enabled:

$new_str = $dbh->quote( $utf_str ); # new_str lost UTF flag.

DBD::mysql doesn't preserve UTF8 flag. This is wrong because in future
if you try to join quoted string with another UTF string then quoted
part would be corrupted.

This patch fix DBD::mysql quote sub which should copy UTF8 flag if it is
was set on src str.

Best regards. Ruslan.

PS. May be PERL_VERSION check should be changed to right values, I don't
know when exactly UTF8 flag was introduced.

--------------010008020703000809000806
Content-Type: application/aegis-patch;
name="mysql_quote_utf_fix.patch"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
filename="mysql_quote_utf_fix.patch"

ZGlmZiAtcnUgREJELW15c3FsLTIuOTAwMy9kYmRpbXAuYyBEQkQtbXlzcWwt Mi45MDAzLW15
L2RiZGltcC5jCi0tLSBEQkQtbXlzcWwtMi45MDAzL2RiZGltcC5jCTIwMDMt MTAtMTcgMjE6
MjA6NTAuMDAwMDAwMDAwICswNDAwCisrKyBEQkQtbXlzcWwtMi45MDAzLW15 L2RiZGltcC5j
CTIwMDQtMDUtMDMgMjE6MTI6NDEuMDAwMDAwMDAwICswNDAwCkBAIC0yNDQ5 LDYgKzI0NDks
MTAgQEAKIAkqc3B0cisrID0gJ1wwJzsgIC8qICBOZXZlciBodXJ0cyBOVUwg dGVybWluYXRp
bmcgYSBQZXJsCiAJCQkgICoJIHN0cmluZyAuLi4KIAkJCSAgKi8KKyNpZiAo KFBFUkxfUkVW
SVNJT04gPj0gNSkgJiYgKFBFUkxfVkVSU0lPTiA+PSA4KSkKKwlpZihTdlVU Rjgoc3RyKSkK
KwkgICAgU3ZVVEY4X29uKHJlc3VsdCk7CisjZW5kaWYKICAgICB9CiAgICAg cmV0dXJuIHJl
c3VsdDsKIH0K

--------------010008020703000809000806
Content-Type: text/plain; charset=us-ascii

--
MySQL Perl Mailing List
For list archives: http://lists.mysql.com/perl
To unsubscribe: http://lists.mysql.com/perl?unsub=gcdmp-msql-mysql-modules@m .gmane.org
--------------010008020703000809000806--

Re: [PATCH][RESUBMIT] mysql_db_quote + UTF8 flagged strings

am 25.08.2004 13:28:23 von Rudy Lippan

On Wed, 25 Aug 2004, Ruslan U. Zakirov wrote:

> Attached patch fix problems for users of perl5.8.x when somebody try
> quote strings with UTF8 flag enabled:

After a quick look over, it looks good, so I'll put this in the next version.
Do you, by chance, have a test script to go with the patch?

> PS. May be PERL_VERSION check should be changed to right values, I don't
> know when exactly UTF8 flag was introduced.

We will find out in testing, right :)

Thank you,

Rudy lippan.

--
MySQL Perl Mailing List
For list archives: http://lists.mysql.com/perl
To unsubscribe: http://lists.mysql.com/perl?unsub=gcdmp-msql-mysql-modules@m .gmane.org

Re: [PATCH][RESUBMIT] mysql_db_quote + UTF8 flagged strings

am 25.08.2004 13:28:23 von Rudy Lippan

Re: [PATCH][RESUBMIT] mysql_db_quote + UTF8 flagged strings

am 25.08.2004 15:56:04 von cubic

--------------070607040905060008090100
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Rudy Lippan wrote:
> On Wed, 25 Aug 2004, Ruslan U. Zakirov wrote:
>
>
>>Attached patch fix problems for users of perl5.8.x when somebody try
>>quote strings with UTF8 flag enabled:
>
>
> After a quick look over, it looks good, so I'll put this in the next version.
> Do you, by chance, have a test script to go with the patch?
>
>
>
>>PS. May be PERL_VERSION check should be changed to right values, I don't
>>know when exactly UTF8 flag was introduced.
>
>
> We will find out in testing, right :)
>
>
> Thank you,
>
> Rudy lippan.
>
>

--------------070607040905060008090100
Content-Type: application/aegis-patch;
name="mysql_quote_utf_fix.patch"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
filename="mysql_quote_utf_fix.patch"

ZGlmZiAtTnJ1IERCRC1teXNxbC0yLjkwMDMvZGJkaW1wLmMgREJELW15c3Fs LTIuOTAwMy1t
eS9kYmRpbXAuYwotLS0gREJELW15c3FsLTIuOTAwMy9kYmRpbXAuYwkyMDAz LTEwLTE3IDIx
OjIwOjUwLjAwMDAwMDAwMCArMDQwMAorKysgREJELW15c3FsLTIuOTAwMy1t eS9kYmRpbXAu
YwkyMDA0LTA1LTAzIDIxOjEyOjQxLjAwMDAwMDAwMCArMDQwMApAQCAtMjQ0 OSw2ICsyNDQ5
LDEwIEBACiAJKnNwdHIrKyA9ICdcMCc7ICAvKiAgTmV2ZXIgaHVydHMgTlVM IHRlcm1pbmF0
aW5nIGEgUGVybAogCQkJICAqCSBzdHJpbmcgLi4uCiAJCQkgICovCisjaWYg KChQRVJMX1JF
VklTSU9OID49IDUpICYmIChQRVJMX1ZFUlNJT04gPj0gOCkpCisJaWYoU3ZV VEY4KHN0cikp
CisJICAgIFN2VVRGOF9vbihyZXN1bHQpOworI2VuZGlmCiAgICAgfQogICAg IHJldHVybiBy
ZXN1bHQ7CiB9CmRpZmYgLU5ydSBEQkQtbXlzcWwtMi45MDAzL01BTklGRVNU IERCRC1teXNx
bC0yLjkwMDMtbXkvTUFOSUZFU1QKLS0tIERCRC1teXNxbC0yLjkwMDMvTUFO SUZFU1QJMjAw
My0wNi0xNiAxMDowNzowNy4wMDAwMDAwMDAgKzA0MDAKKysrIERCRC1teXNx bC0yLjkwMDMt
bXkvTUFOSUZFU1QJMjAwNC0wOC0yNSAxNzoyODowNC4wMDAwMDAwMDAgKzA0 MDAKQEAgLTI4
LDYgKzI4LDcgQEAKIHQvaW5zZXJ0aWQudAogdC9teXNxbC5kYnRlc3QKIHQv bXlzcWwubXRl
c3QKK3QvNDBxdW90ZS50CiBkYmRpbXAuaAogY29uc3RhbnRzLmgKIGxpYi9N eXNxbC5wbQpk
aWZmIC1OcnUgREJELW15c3FsLTIuOTAwMy90LzQwbGlzdGZpZWxkcy50IERC RC1teXNxbC0y
LjkwMDMtbXkvdC80MGxpc3RmaWVsZHMudAotLS0gREJELW15c3FsLTIuOTAw My90LzQwbGlz
dGZpZWxkcy50CTIwMDMtMTAtMjIgMjI6Mjk6MzUuMDAwMDAwMDAwICswNDAw CisrKyBEQkQt
bXlzcWwtMi45MDAzLW15L3QvNDBsaXN0ZmllbGRzLnQJMjAwNC0wOC0yNSAx Nzo0MjowNS4w
MDAwMDAwMDAgKzA0MDAKQEAgLTEzMywxOCArMTMzLDQgQEAKIAlvciAhJHZl cmJvc2Ugb3Ig
cHJpbnRmKCJOVU1fT0ZfRklFTERTIGlzICVzLCBub3QgemVyby5cbiIsCiAJ CQkgICAgICAg
JGN1cnNvci0+eydOVU1fT0ZfRklFTERTJ30pOwogICAgIFRlc3QoJHN0YXRl IG9yICh1bmRl
ZiAkY3Vyc29yKSBvciAxKTsKLQotICAgICMKLSAgICAjICBUZXN0IGRpZmZl cmVudCBmbGF2
b3VycyBvZiBxdW90ZS4gTmVlZCB0byB3b3JrIGFyb3VuZCBhIGJ1ZyBpbgot ICAgICMgIERC
SSAxLjAyIC4uLgotICAgICMKLSAgICBteSAkcXVvdGVkOwotICAgIGlmICgh JHN0YXRlKSB7
Ci0JJHF1b3RlZCA9IGV2YWwgeyAkZGJoLT5xdW90ZSgwLCBEQkk6OlNRTF9J TlRFR0VSKCkp
IH07Ci0gICAgfQotICAgIFRlc3QoJHN0YXRlIG9yICRAICBvciAgJHF1b3Rl ZCBlcSAwKTsK
LSAgICBpZiAoISRzdGF0ZSkgewotCSRxdW90ZWQgPSBldmFsIHsgJGRiaC0+ cXVvdGUoJ2Fi
YycsIERCSTo6U1FMX1ZBUkNIQVIoKSkgfTsKLSAgICB9Ci0gICAgVGVzdCgk c3RhdGUgb3Ig
JEAgb3IgJHF1b3RlZCBlcSBxeydhYmMnfSk7CiB9CmRpZmYgLU5ydSBEQkQt bXlzcWwtMi45
MDAzL3QvNDBxdW90ZS50IERCRC1teXNxbC0yLjkwMDMtbXkvdC80MHF1b3Rl LnQKLS0tIERC
RC1teXNxbC0yLjkwMDMvdC80MHF1b3RlLnQJMTk3MC0wMS0wMSAwMzowMDow MC4wMDAwMDAw
MDAgKzAzMDAKKysrIERCRC1teXNxbC0yLjkwMDMtbXkvdC80MHF1b3RlLnQJ MjAwNC0wOC0y
NSAxNzo1NDoxNi4wMDAwMDAwMDAgKzA0MDAKQEAgLTAsMCArMSw3MiBAQAor IyEvdXNyL2xv
Y2FsL2Jpbi9wZXJsCisjCisjICAgVGhpcyBpcyBhIHRlc3QgZm9yIHF1b3Rl IGNhbGwKKyMK
KworCisjCisjICAgTWFrZSAtdyBoYXBweQorIworJHRlc3RfZHNuID0gJyc7 CiskdGVzdF91
c2VyID0gJyc7CiskdGVzdF9wYXNzd29yZCA9ICcnOworCisKKyMKKyMgICBJ bmNsdWRlIGxp
Yi5wbAorIwordXNlIERCSTsKK3VzZSB2YXJzIHF3KCR2ZXJib3NlKTsKKwor JG1kcml2ZXIg
PSAiIjsKK2ZvcmVhY2ggJGZpbGUgKCJsaWIucGwiLCAidC9saWIucGwiKSB7 CisgICAgZG8g
JGZpbGU7IGlmICgkQCkgeyBwcmludCBTVERFUlIgIkVycm9yIHdoaWxlIGV4 ZWN1dGluZyBs
aWIucGw6ICRAXG4iOworCQkJICAgZXhpdCAxMDsKKwkJICAgICAgfQorICAg IGlmICgkbWRy
aXZlciBuZSAnJykgeworCWxhc3Q7CisgICAgfQorfQorCitzdWIgU2VydmVy RXJyb3IoKSB7
CisgICAgcHJpbnQgU1RERVJSICgiQ2Fubm90IGNvbm5lY3Q6ICIsICREQkk6 OmVycnN0ciwg
IlxuIiwKKwkiXHRFaXRoZXIgeW91ciBzZXJ2ZXIgaXMgbm90IHVwIGFuZCBy dW5uaW5nIG9y
IHlvdSBoYXZlIG5vXG4iLAorCSJcdHBlcm1pc3Npb25zIGZvciBhY2Vzc2lu ZyB0aGUgRFNO
ICR0ZXN0X2Rzbi5cbiIsCisJIlx0VGhpcyB0ZXN0IHJlcXVpcmVzIGEgcnVu bmluZyBzZXJ2
ZXIgYW5kIHdyaXRlIHBlcm1pc3Npb25zLlxuIiwKKwkiXHRQbGVhc2UgbWFr ZSBzdXJlIHlv
dXIgc2VydmVyIGlzIHJ1bm5pbmcgYW5kIHlvdSBoYXZlXG4iLAorCSJcdHBl cm1pc3Npb25z
LCB0aGVuIHJldHJ5LlxuIik7CisgICAgZXhpdCAxMDsKK30KKworIworIyAg IE1haW4gbG9v
cDsgbGVhdmUgdGhpcyB1bnRvdWNoZWQsIHB1dCB0ZXN0cyBhZnRlciBjcmVh dGluZworIyAg
IHRoZSBuZXcgdGFibGUuCisjCit3aGlsZSAoVGVzdGluZygpKSB7CisgICAg IworICAgICMg
ICBDb25uZWN0IHRvIHRoZSBkYXRhYmFzZQorICAgIFRlc3QoJHN0YXRlIG9y ICRkYmggPSBE
QkktPmNvbm5lY3QoJHRlc3RfZHNuLCAkdGVzdF91c2VyLCAkdGVzdF9wYXNz d29yZCkpCisJ
b3IgU2VydmVyRXJyb3IoKTsKKworICAgICMgIFRlc3QgZGlmZmVyZW50IGZs YXZvdXJzIG9m
IHF1b3RlLiBOZWVkIHRvIHdvcmsgYXJvdW5kIGEgYnVnIGluCisgICAgIyAg REJJIDEuMDIg
Li4uCisgICAgIworCisgICAgbXkgJHF1b3RlZDsKKyAgICBpZiAoISRzdGF0 ZSkgeworCSRx
dW90ZWQgPSBldmFsIHsgJGRiaC0+cXVvdGUoMCwgREJJOjpTUUxfSU5URUdF UigpKSB9Owor
ICAgIH0KKyAgICBUZXN0KCRzdGF0ZSBvciAkQCBvciAkcXVvdGVkIGVxIDAp OworICAgIGlm
ICghJHN0YXRlKSB7CisJJHF1b3RlZCA9IGV2YWwgeyAkZGJoLT5xdW90ZSgn YWJjJywgREJJ
OjpTUUxfVkFSQ0hBUigpKSB9OworICAgIH0KKyAgICBUZXN0KCRzdGF0ZSBv ciAkQCBvciAk
cXVvdGVkIGVxIHF7J2FiYyd9KTsKKworICAgIGV2YWwgeyByZXF1aXJlIEVu Y29kZTsgfTsK
KyAgICB1bmxlc3MoICRAICkgeworCWlmICghJHN0YXRlKSB7CisJICAgICRx dW90ZWQgPSBl
dmFsIHsgJGRiaC0+cXVvdGUoIlx4ezQ0Mn1ceHs0MzV9XHh7NDQxfVx4ezQ0 Mn0iLCBEQkk6
OlNRTF9WQVJDSEFSKCkpIH07CisJfQorCVRlc3QoJHN0YXRlIG9yICRAIG9y IChFbmNvZGU6
OmlzX3V0ZjgoJHF1b3RlZCkgYW5kICRxdW90ZWQgZXEgIidceHs0NDJ9XHh7 NDM1fVx4ezQ0
MX1ceHs0NDJ9JyIpKTsKKyAgICB9Cit9Cg==

--------------070607040905060008090100
Content-Type: text/plain; charset=us-ascii

--
MySQL Perl Mailing List
For list archives: http://lists.mysql.com/perl
To unsubscribe: http://lists.mysql.com/perl?unsub=gcdmp-msql-mysql-modules@m .gmane.org
--------------070607040905060008090100--

Re: [PATCH][RESUBMIT] mysql_db_quote + UTF8 flagged strings

am 25.08.2004 15:56:04 von cubic