Minor bugs in libwww-perl-5.803 fixed in Debian

Hello everyone. I've taken over maintenance of libwww-perl inside of
debian (from Michael Dorman). With the release coming soon, I've
updated into unstable/ the newest version of libwww-perl from CPAN. It
is the same as the distribution, with two very small bugfixes, which you
may wish to roll into the next version:

I'd attach patches, but these are both one-character fixes

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=283916

Fix: lib/Net/HTTP (line 35):
my $s = Net::HTTP->new(Host => "www.perl.com") || die $@;

(Fully quotes www.perl.com in the example)


http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=286775

Fix: lib/Net/HTTP/Methods.pm (line 432):
$chunk_len =~ s/\;.*//; # ignore potential chunk parameters

(Escapes the semi)

I know these are incredibly minor, but thanks for taking the time to
look at them.

--Jay Bonci
jaybonci@debian.org

--
Jay Bonci

Re: Minor bugs in libwww-perl-5.803 fixed in Debian

--rV8arf8D5Dod9UkK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Tue, Dec 28, 2004 at 11:29:40PM -0500, Jay Bonci wrote:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D286775
>=20
> Fix: lib/Net/HTTP/Methods.pm (line 432):
> $chunk_len =3D~ s/\;.*//; # ignore potential chunk parameters
>=20
> (Escapes the semi)

What's wrong with semicolon not being escaped?
Please explain.

> --=20
> Jay Bonci

--=20
Alexey Tourbin
ALT Linux Team

--rV8arf8D5Dod9UkK
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFB0tdFfBKgtDjnu0YRAs4MAKDOp1D2/jtGMRMTz3/XD4w5aICSjACf VUdg
5ZajIvvLpv9AVMTesauS58g=
=5FAo
-----END PGP SIGNATURE-----

--rV8arf8D5Dod9UkK--

Re: Minor bugs in libwww-perl-5.803 fixed in Debian

Jay Bonci writes:

> Hello everyone. I've taken over maintenance of libwww-perl inside of
> debian (from Michael Dorman). With the release coming soon, I've
> updated into unstable/ the newest version of libwww-perl from CPAN. It
> is the same as the distribution, with two very small bugfixes, which you
> may wish to roll into the next version:
>
> I'd attach patches, but these are both one-character fixes
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=283916
>
> Fix: lib/Net/HTTP (line 35):
> my $s = Net::HTTP->new(Host => "www.perl.com") || die $@;
>
> (Fully quotes www.perl.com in the example)

Applied.

> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=286775
>
> Fix: lib/Net/HTTP/Methods.pm (line 432):
> $chunk_len =~ s/\;.*//; # ignore potential chunk parameters
>
> (Escapes the semi)

This fix is bogus. The semi does not make any difference, but I've
now applied the following patch that I think avoids the warnings shown
in that bug report.

Regards,
Gisle


Index: lib/Net/HTTP/Methods.pm
============================================================ =======
RCS file: /cvsroot/libwww-perl/lwp5/lib/Net/HTTP/Methods.pm,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -p -u -r1.17 -r1.18
--- lib/Net/HTTP/Methods.pm 15 Nov 2004 14:16:07 -0000 1.17
+++ lib/Net/HTTP/Methods.pm 30 Dec 2004 12:28:14 -0000 1.18
@@ -426,8 +426,8 @@ sub read_entity_body {
die "Missing newline after chunk data: '$line'"
if !defined($line) || $line ne "";
$line = my_readline($self);
- die "EOF when chunk header expected" unless defined($line);
}
+ die "EOF when chunk header expected" unless defined($line);
my $chunk_len = $line;
$chunk_len =~ s/;.*//; # ignore potential chunk parameters
unless ($chunk_len =~ /^([\da-fA-F]+)\s*$/) {