Hi guys I need help. I have page vich is linked with database, and it needs
to have some sort of editing text. No addning, or deleting. I know how to
display text from database, but I am stuck on editng it. So question is how
to edit page with ID let's say 10 (getting "old" text in text area for
change and submitnig it to change). Every page in tbale has ID and text.
Vedran Grubac wrote:
> Hi guys I need help. I have page vich is linked with database, and it needs
> to have some sort of editing text. No addning, or deleting. I know how to
> display text from database, but I am stuck on editng it. So question is how
> to edit page with ID let's say 10 (getting "old" text in text area for
> change and submitnig it to change). Every page in tbale has ID and text.
What have you tried in the last few days? Have you googled for "ASP
Database Update Tutorial"? Have you found some code and tried it?
Have you got some error message from trying it? If so, post the code
and the error message, telling us which line caused the error. Also
tell us which type and version of database you are using.
--
Mike Brind
Ok database is access 2003, mdb
code is
update_form.asp
<%
Dim adoCon
Dim rsText
Dim strSQL
Dim lngRecordNo
lngRecordNo = CLng(Request.QueryString("ID"))
Set adoCon = Server.CreateObject("ADODB.Connection")
adoCon.Open "DRIVER={Microsoft Access Driver (*.mdb)}; DBQ=" &
Server.MapPath("tim.mdb")
Set rsText = Server.CreateObject("ADODB.Recordset")
strSQL = "SELECT str.* FROM str WHERE ID=" & lngRecordNo
rsText.Open strSQL, adoCon
%>
Lots to go on here. See inline comments:
vgrubac@gmail.com wrote:
> Ok database is access 2003, mdb
> code is
> update_form.asp
> <%
> Dim adoCon
> Dim rsText
> Dim strSQL
> Dim lngRecordNo
>
> lngRecordNo = CLng(Request.QueryString("ID"))
>
> Set adoCon = Server.CreateObject("ADODB.Connection")
> adoCon.Open "DRIVER={Microsoft Access Driver (*.mdb)}; DBQ=" &
> Server.MapPath("tim.mdb")
You shouldn't be using the ODBC driver. It's been deprecated. You
should be using the native OLEDB driver instead. See
http://www.aspfaq.com/show.asp?id=2126.
Your path suggests you have the mdb file in the same directory as the
script. You should not do this. It should be kept somewhere outside
the root of the website. Otherwise anyone can browse to it and
download a copy.
> Set rsText = Server.CreateObject("ADODB.Recordset")
> strSQL = "SELECT str.* FROM str WHERE ID=" & lngRecordNo
You shouldn't SELECT * unless you really do want to use all the fields
in your database. I see you do actually use all the fields in this
case, but from a legibility and maintainability point of view, this is
still poor practice. And in any case, you shouldn't select the ID
number. You already have that in the Request.QueryString collection.
See here: http://www.adopenstatic.com/faq/selectstarisbad.asp
> rsText.Open strSQL, adoCon
> %>
>
>
Ok I have one questin more (I konw, I konw I am bothering :(()
> Yes. Use a saved parameter query to do the update. Go into Access and
> in the Query pane, select Create Query in Design View. Close the Add
> Table dialogue box that appears and switch to SQL view. Copy and paste
> the following:
>
> UPDATE str SET Stranica = [p1], [Text] = [p2] WHERE ID = [p3]
>
> and save that as qUpdateComment. Run the query. You will be prompted
> for values for p1,p2,p3. Put something sensible in to make sure it
> works. p3 should obviously be an existing ID number.
>
> [Text] has square brackets around it to get round the reserved word
> problem.
> Consider renaming it to Comments or something.
>
I made that, and it works, and text is changed to samothing, query
works in
access
> Now your update_form.asp code should look like this:
>
Is that update_form, or entry_update wich is called after hitting
submit
button, if is first one, where it goes, becouse update_form retrives
data
from database in form?
> <%
> dim p1,p2,p3,adocon
>
> p1 = Request.Form("name")
> p2 = Request.Form("comments")
> p3 = Request.Form("ID_no")
>
> set adocon = createobject("ADODB.Connection")
> adocon.open "
> adocon.qUpdateComment p1,p2,p3
> adocon.close: set adocon = nothing
> response.write "Your comments have been updated"
> %>
>
This should be connection or?
set adocon = createobject("ADODB.Connection")
adocon.Open "DRIVER={Microsoft Access Driver (*.mdb)}; DBQ=" &
Server.MapPath("tim.mdb")
And after everything I get error
ADODB.Connection (0x800A0E7C)
Parameter object is improperly defined. Inconsistent or incomplete
information was provided.
for:
adocon.qUpdateComment p1,p2,p3
p.s. any good book convering this?
vgrubac@gmail.com wrote:
> Ok I have one questin more (I konw, I konw I am bothering :(()
>
> > Yes. Use a saved parameter query to do the update. Go into Access and
> > in the Query pane, select Create Query in Design View. Close the Add
> > Table dialogue box that appears and switch to SQL view. Copy and paste
> > the following:
> >
> > UPDATE str SET Stranica = [p1], [Text] = [p2] WHERE ID = [p3]
> >
> > and save that as qUpdateComment. Run the query. You will be prompted
> > for values for p1,p2,p3. Put something sensible in to make sure it
> > works. p3 should obviously be an existing ID number.
> >
> > [Text] has square brackets around it to get round the reserved word
> > problem.
> > Consider renaming it to Comments or something.
> >
> I made that, and it works, and text is changed to samothing, query
> works in
> access
>
> > Now your update_form.asp code should look like this:
> >
>
> Is that update_form, or entry_update wich is called after hitting
> submit
> button, if is first one, where it goes, becouse update_form retrives
> data
> from database in form?
>
> > <%
> > dim p1,p2,p3,adocon
> >
> > p1 = Request.Form("name")
> > p2 = Request.Form("comments")
> > p3 = Request.Form("ID_no")
> >
> > set adocon = createobject("ADODB.Connection")
> > adocon.open "
> > adocon.qUpdateComment p1,p2,p3
> > adocon.close: set adocon = nothing
> > response.write "Your comments have been updated"
> > %>
> >
> This should be connection or?
>
> set adocon = createobject("ADODB.Connection")
> adocon.Open "DRIVER={Microsoft Access Driver (*.mdb)}; DBQ=" &
> Server.MapPath("tim.mdb")
>
> And after everything I get error
> ADODB.Connection (0x800A0E7C)
> Parameter object is improperly defined. Inconsistent or incomplete
> information was provided.
> for:
> adocon.qUpdateComment p1,p2,p3
>
> p.s. any good book convering this?
Sorry - that should have been entry_update.asp - or whatever page you
do your processing on. Peronally, I always post this sort of form page
back to itself and have both the form and the processing code on the
same page. Then I test to see if the form has been submitted:
If Request.Form("ID")<>"" then
'process the results
Else
'present the form
End If
The error you get is telling you that a value is missing - probably in
p3. Check the name of the hidden ID field in your form against the
processing code where p3 picks up its value. They should both be named
ID_no (or both be named ID - whichever you prefer). I got that error
the first time I ran your code - that's how I noticed that you had
named the form field one thing in the form, and another in the
processing code.
Get rid of the ODBC driver, please. Change your connection string to
this:
Provider=Microsoft.Jet.OLEDB.4.0;Data Source=" &
Server.Mappath("tim.mdb")
As far as books are concerned, I have Beginning ASP 3.0 (Wrox) and ASP
Developers Guide (McGraw Hill). Both are good for beginners. Neither
of them covers saved parameter queries, though. That's something I
picked up from regularly visiting this group.
--
Mike Brind
"Mike Brind"
news:1144534459.975205.152070@u72g2000cwu.googlegroups.com.. .
>
Thanks man, everythung works OK now, last problem I fgured out without your
post. Somethime all you need is a good night sleep. Simple as that.