Re: FWD: [dbi] pod patch for ParamArrays and now optional ArrayTupleStatus

On Fri, Apr 28, 2006 at 05:59:19PM +0100, Martin J. Evans wrote:
> Tim,
>
> Just a gentle reminder that I posted the attached patch to the POD for
> ParamArrays (at your request) but I don't see it in subversion as yet
> and I also mailed about a ParamArrays test being missing from around
> line 1982 (in subversion today) for DBI.xs (a similar change to the
> Username one you added in 1.51).
>
> Perhaps you missed them.

I have at least the patch. The other items I may have flagged the emails
but haven't gone and checked. I've been working on some significant
changes to profiling[1] recently. Once those are in then I'll be checking
back through flagged emails for anything else that needs doing.

Tim.

[1] Including having code refs in Path and thus the ability to accumulate
profiled data against an simplified version of the Statement SQL.
That, in turn, enables effective profiling of code that doesn't use
placeholders.

p.s. Just to be sure please resend (just to me) anything that needs doing.
Thanks.

Re: FWD: [dbi] pod patch for ParamArrays and now optional ArrayTupleStatus

Tim,

I may have missed the pod patch in my email yesterday - sorry.
My original email to dbi-users explaining the patch is below.
I've redone the patch against the latest subversion tree.

Also, a test for "ParamArrays" needs adding around line 1982 in DBI.xs as per
the change you made in 1.51 for "Username".

Original email:

As promised last night.

I've documented ParamArrays as I found it rather than perhaps what was
intended. Specifically, the drivers I'm using return undef for ParamArrays if
there aren't any rather than a ref to a hash with keys but no values (as per
ParamValues).

I also amended the ArrayTupleStatus which is optional since 1.38.

Thanks again for pointing out ParamArrays.

Martin
--
Martin J. Evans
Easysoft Ltd, UK
http://www.easysoft.com


On 29-Apr-2006 Tim Bunce wrote:
> On Fri, Apr 28, 2006 at 05:59:19PM +0100, Martin J. Evans wrote:
>> Tim,
>>
>> Just a gentle reminder that I posted the attached patch to the POD for
>> ParamArrays (at your request) but I don't see it in subversion as yet
>> and I also mailed about a ParamArrays test being missing from around
>> line 1982 (in subversion today) for DBI.xs (a similar change to the
>> Username one you added in 1.51).
>>
>> Perhaps you missed them.
>
> I have at least the patch. The other items I may have flagged the emails
> but haven't gone and checked. I've been working on some significant
> changes to profiling[1] recently. Once those are in then I'll be checking
> back through flagged emails for anything else that needs doing.
>
> Tim.
>
> [1] Including having code refs in Path and thus the ability to accumulate
> profiled data against an simplified version of the Statement SQL.
> That, in turn, enables effective profiling of code that doesn't use
> placeholders.
>
> p.s. Just to be sure please resend (just to me) anything that needs doing.
> Thanks.