CVS and open cursor

--cNdxnHkX5QqsyA0e
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hello,

Hiroshi have you commited all changes? I have still
"The cursor is open." problem with CVS. So I try fix it myself.
Please could you commit the changes more frequently or send
the patches to the list so I can cooperate?

My patch is based on PGAPI_FreeStmt(hstmt, SQL_CLOSE) is called
from PGAPI_MoreResults when this returns SQL_NO_DATA.
Patch (againist CVS HEAD) attached.

Regards,

Luf

--cNdxnHkX5QqsyA0e
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="psqlodbc_cursor_open.diff"

diff -c psqlodbc.orig\results.c psqlodbc\results.c
*** psqlodbc.orig\results.c Mon May 29 20:26:46 2006
--- psqlodbc\results.c Wed Jun 07 21:00:44 2006
***************
*** 1838,1844 ****
--- 1838,1847 ----
stmt->currTuple = -1;
}
else
+ {
+ PGAPI_FreeStmt(hstmt, SQL_CLOSE);
ret = SQL_NO_DATA_FOUND;
+ }
mylog("%s: returning %d\n", func, ret);
return ret;
}

--cNdxnHkX5QqsyA0e
Content-Type: text/plain
Content-Disposition: inline
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

--cNdxnHkX5QqsyA0e--

Re: CVS and open cursor

Ludek Finstrle wrote:
> Hello,
>
> Hiroshi have you commited all changes?

Unfortunately I have pretty many changes in my local source.

> I have still
> "The cursor is open." problem with CVS. So I try fix it myself.
> Please could you commit the changes more frequently or send
> the patches to the list so I can cooperate?

OK I would commit the changes this weekend.

> My patch is based on PGAPI_FreeStmt(hstmt, SQL_CLOSE) is called
> from PGAPI_MoreResults when this returns SQL_NO_DATA.
> Patch (againist CVS HEAD) attached.

Please commit the patch.

regards,
Hiroshi Inoue

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

Re: CVS and open cursor

Hiroshi Inoue wrote:
> Ludek Finstrle wrote:
>> Hello,
>>
>> Hiroshi have you commited all changes?
>
> Unfortunately I have pretty many changes in my local source.
>
>> I have still
>> "The cursor is open." problem with CVS. So I try fix it myself.
>> Please could you commit the changes more frequently or send
>> the patches to the list so I can cooperate?
>
> OK I would commit the changes this weekend.

Sorry, I've been busy the last weekend.
I would commit the changes tonight or tomorrow.

regards,
Hiroshi Inoue

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Re: CVS and open cursor

> > My patch is based on PGAPI_FreeStmt(hstmt, SQL_CLOSE) is called
> > from PGAPI_MoreResults when this returns SQL_NO_DATA.
> > Patch (againist CVS HEAD) attached.
>
> Please commit the patch.

Patch commited.

Regards,

Luf

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster