Re: [PATCH] Get DBI to pass tests with bleadperl (was Re: Status of Perl 5.10 TODO list)

--Next_1161752150---0-59.160.240.216-27212
Content-type: text/plain;
charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

=A0Hi Moderator, I am unable to unsubscribe from this group. Can=
anyone help. Thanks,=0AMurali On Mon, 23 Oct 2006 Steve Pe=
ters wrote :=0A>On Sat, Oct 14, 2006 at 08:40:14AM +0200, Andreas J. Koenig=
wrote:=0A> > >>>>> On Fri, 13 Oct 2006 17:00:46 +0200, demerphq gmail.com> said:=0A> >=0A> > > Are there any other issues not listed abov=
e?=0A> >=0A> > Showstopper is that DBI doesn't compile. There seems to be n=
o RT=0A> > ticket but xray has some hits:=0A> >=0A> > http://www.xray.mpe.m=
pg.de/cgi-bin/w3glimpse/perl5-porters?query=3Dbreaks+dbi&err ors=3D0&case=3D=
on&maxfiles=3D100&maxlines=3D30=0A> >=0A>=0A>I seemed to get it to compile,=
but it blew up on assertions on assertions.=0A>With some help from Nichola=
s Clark, the following patch gets DBI-1.52 to=0A>compile *and* pass all of =
its tests.=0A>=0A>Steve Peters=0A>steve@fisharerojo.org=0A>=0A>--- DBI.xs.o=
ld 2006-10-23 09:08:08.000000000 -0500=0A>+++ DBI.xs 2006-10-23 09:02=
:50.000000000 -0500=0A>@@ -2615,7 +2615,7 @@=0A> */=0A> if (SvROK=
(h) && SvRMAGICAL(SvRV(h)) && (mg=3Dmg_find(SvRV(h),'P'))!=3DNULL) {=0A>=0A=
>- if (mg->mg_obj==NULL || !SvOK(mg->mg_obj) || SvPVX(mg->mg_obj=
)==NULL) { /* maybe global destruction */=0A>+ if (mg->mg_obj=
==NULL || !SvOK(mg->mg_obj) || SvRV(mg->mg_obj)==NULL) { /* maybe =
global destruction */=0A> if (trace_level >=3D 3)=0A> =
PerlIO_printf(DBILOGFP,=0A> "%c <> %s for %s=
ignored (inner handle gone)\n",=0A> =0A
--Next_1161752150---0-59.160.240.216-27212--