[psqlODBC 08.02.0401] Typo

Hi,

while browsing the source I found a typo in socket.c::SOCK_Constructor()

Original code:
if (rv)
rv->buffer_size =
conn->connInfo.drivers.socket_buffersize;
else
rv->buffer_size = globals.socket_buffersize;

But since rv is allocated and checked before, the test should probably be:
if (conn)
rv->buffer_size =
conn->connInfo.drivers.socket_buffersize;
else
rv->buffer_size = globals.socket_buffersize;

Rainer

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

Re: [psqlODBC 08.02.0401] Typo

Rainer Bauer wrote:
> Hi,
>
> while browsing the source I found a typo in socket.c::SOCK_Constructor()
>
> Original code:
> if (rv)
> rv->buffer_size =
> conn->connInfo.drivers.socket_buffersize;
> else
> rv->buffer_size = globals.socket_buffersize;
>
> But since rv is allocated and checked before, the test should probably be:
> if (conn)
> rv->buffer_size =
> conn->connInfo.drivers.socket_buffersize;
> else
> rv->buffer_size = globals.socket_buffersize;

Oops you are right.
Thanks.

regards,
Hiroshi Inoue

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster