[Fwd: Re: ports/134749: www/mod_perl bus error after 1.31 update]

[Fwd: Re: ports/134749: www/mod_perl bus error after 1.31 update]

am 05.06.2009 08:26:03 von Philip Gollucci

--------------090900080007060608010901
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit

fixed....

hth

--------------090900080007060608010901
Content-Type: message/rfc822;
name="Re: ports/134749: www/mod_perl bus error after 1.31 update.eml"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename*0="Re: ports/134749: www/mod_perl bus error after 1.31 update.e";
filename*1="ml"

Return-Path:
Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53])
by piccollo.p6m7g8.net (8.14.3/8.14.3) with ESMTP id n556091B078963
for ; Fri, 5 Jun 2009 02:00:09 -0400 (EDT)
(envelope-from gnats@FreeBSD.org)
Received: from hub.freebsd.org (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
by mx2.freebsd.org (Postfix) with ESMTP id 3F21215061F
for ; Fri, 5 Jun 2009 06:00:09 +0000 (UTC)
(envelope-from gnats@FreeBSD.org)
Received: by hub.freebsd.org (Postfix)
id 3C1031065674; Fri, 5 Jun 2009 06:00:09 +0000 (UTC)
Delivered-To: pgollucci@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
by hub.freebsd.org (Postfix) with ESMTP id 3AA85106566C
for ; Fri, 5 Jun 2009 06:00:09 +0000 (UTC)
(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
by mx1.freebsd.org (Postfix) with ESMTP id 27C228FC19
for ; Fri, 5 Jun 2009 06:00:09 +0000 (UTC)
(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n55608ax007224
for ; Fri, 5 Jun 2009 06:00:08 GMT
(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n55608Z7007223;
Fri, 5 Jun 2009 06:00:08 GMT
(envelope-from gnats)
Date: Fri, 5 Jun 2009 06:00:08 GMT
Message-Id: <200906050600.n55608Z7007223@freefall.freebsd.org>
To: pgollucci@FreeBSD.org
Cc:
From: "Philip M. Gollucci"
Subject: Re: ports/134749: www/mod_perl bus error after 1.31 update
Reply-To: "Philip M. Gollucci"
X-Virus-Scanned: ClamAV 0.94.2/9425/Thu Jun 4 23:55:18 2009 on piccollo.p6m7g8.net
X-Virus-Status: Clean
X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED,
SPF_PASS autolearn=ham version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on piccollo.p6m7g8.net

The following reply was made to PR ports/134749; it has been noted by GNATS.

From: "Philip M. Gollucci"
To: bug-followup@FreeBSD.org, Troy ,
Tim Zingelman
Cc:
Subject: Re: ports/134749: www/mod_perl bus error after 1.31 update
Date: Fri, 5 Jun 2009 01:59:26 -0400

--------------080902040507050309010103
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

I've committed the fix upstream. FBSD port next.

--------------080902040507050309010103
Content-Type: message/rfc822; name="svn commit: r781917 - in
/perl/modperl/branches/1.x: Changes src/modules/perl/mod_perl.c.eml"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename*0="svn commit: r781917 - in /perl/modperl/branches/1.x: Changes";
filename*1=" src/modules/perl/mod_perl.c.eml"

Return-Path:
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
by piccollo.p6m7g8.net (8.14.3/8.14.3) with SMTP id n555vlEY078897
for ; Fri, 5 Jun 2009 01:57:48 -0400 (EDT)
(envelope-from modperl-cvs-return-6354-pgollucci=p6m7g8.com@perl.apache.org )
Received: (qmail 38574 invoked by uid 500); 5 Jun 2009 05:57:42 -0000
Mailing-List: contact modperl-cvs-help@perl.apache.org; run by ezmlm
Precedence: bulk
list-help:
list-unsubscribe:
List-Post:
Reply-To: dev@perl.apache.org
List-Id:
Delivered-To: mailing list modperl-cvs@perl.apache.org
Received: (qmail 38565 invoked by uid 99); 5 Jun 2009 05:57:42 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jun 2009 05:57:42 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4)
by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jun 2009 05:57:39 +0000
Received: by eris.apache.org (Postfix, from userid 65534)
id 2C8A82388849; Fri, 5 Jun 2009 05:57:18 +0000 (UTC)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r781917 - in /perl/modperl/branches/1.x: Changes
src/modules/perl/mod_perl.c
Date: Fri, 05 Jun 2009 05:57:18 -0000
To: modperl-cvs@perl.apache.org
From: pgollucci@apache.org
X-Mailer: svnmailer-1.0.8
Message-Id: <20090605055718.2C8A82388849@eris.apache.org>
X-Virus-Checked: Checked by ClamAV on apache.org
X-Virus-Scanned: ClamAV 0.94.2/9425/Thu Jun 4 23:55:18 2009 on piccollo.p6m7g8.net
X-Virus-Status: Clean
X-Spam-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,
RCVD_IN_DNSWL_MED,SPF_PASS autolearn=ham version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on piccollo.p6m7g8.net

Author: pgollucci
Date: Fri Jun 5 05:57:17 2009
New Revision: 781917

URL: http://svn.apache.org/viewvc?rev=781917&view=rev
Log:
Address FreeBSD PR: ports/134749

This is actually a bug in gcc 4.2.1?x where
the array is optimized incorrectly causing
sefaults during startup.

Apparently the bug does not exist in FreeBSD 8
but is an issue in 7.x.

Reported by: Troy
Submitted by: Tim Zingelman
Reviewed by: myself


Modified:
perl/modperl/branches/1.x/Changes
perl/modperl/branches/1.x/src/modules/perl/mod_perl.c

Modified: perl/modperl/branches/1.x/Changes
URL: http://svn.apache.org/viewvc/perl/modperl/branches/1.x/Chang es?rev=781917&r1=781916&r2=781917&view=diff
============================================================ ==================
--- perl/modperl/branches/1.x/Changes (original)
+++ perl/modperl/branches/1.x/Changes Fri Jun 5 05:57:17 2009
@@ -10,6 +10,10 @@

=item 1.32-dev

+Work around a gcc optimization specific bug which
+cuased seg faults on FreeBSD 7.x during mod_perl startup.
+[Tim Zingelman ]
+
=item 1.31 May 11, 2009

Fix static APACI build on Mac OS X. [Gozer]

Modified: perl/modperl/branches/1.x/src/modules/perl/mod_perl.c
URL: http://svn.apache.org/viewvc/perl/modperl/branches/1.x/src/m odules/perl/mod_perl.c?rev=781917&r1=781916&r2=781917&view=d iff
============================================================ ==================
--- perl/modperl/branches/1.x/src/modules/perl/mod_perl.c (original)
+++ perl/modperl/branches/1.x/src/modules/perl/mod_perl.c Fri Jun 5 05:57:17 2009
@@ -596,6 +596,7 @@
void perl_startup (server_rec *s, pool *p)
{
char *argv[] = { NULL, NULL, NULL, NULL, NULL, NULL, NULL };
+ char **temp_argv=argv;
char **entries, *dstr;
int status, i, argc=1;
dPSRV(s);
@@ -679,7 +680,7 @@
MP_TRACE_g(fprintf(stderr, "..."));

#ifdef PERL_SYS_INIT
- PERL_SYS_INIT(&argc,(char***)&argv);
+ PERL_SYS_INIT(&argc,(char***)&temp_argv);
#endif

#ifndef perl_init_i18nl10n


--------------080902040507050309010103--

--------------090900080007060608010901
Content-Type: message/rfc822; name="cvs commit: ports/www/mod_perl Makefile
ports/www/mod_perl/files patch-src__modules__perl__mod_perl.c.eml"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename*0="cvs commit: ports/www/mod_perl Makefile ports/www/mod_perl/f";
filename*1="iles patch-src__modules__perl__mod_perl.c.eml"

Return-Path:
Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53])
by piccollo.p6m7g8.net (8.14.3/8.14.3) with ESMTP id n556NHTX079426
for ; Fri, 5 Jun 2009 02:23:17 -0400 (EDT)
(envelope-from owner-ports-committers@FreeBSD.org)
Received: from hub.freebsd.org (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
by mx2.freebsd.org (Postfix) with ESMTP id 6E2CE1612C4
for ; Fri, 5 Jun 2009 06:23:14 +0000 (UTC)
(envelope-from owner-ports-committers@FreeBSD.org)
Received: by hub.freebsd.org (Postfix)
id 8163C10656EA; Fri, 5 Jun 2009 06:23:13 +0000 (UTC)
Delivered-To: pgollucci@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 538)
id 2E76A1065672; Fri, 5 Jun 2009 06:23:12 +0000 (UTC)
Delivered-To: ports-committers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
by hub.freebsd.org (Postfix) with ESMTP id E5F5F106566C;
Fri, 5 Jun 2009 06:23:06 +0000 (UTC)
(envelope-from pgollucci@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29])
by mx1.freebsd.org (Postfix) with ESMTP id D47FC8FC0A;
Fri, 5 Jun 2009 06:23:06 +0000 (UTC)
(envelope-from pgollucci@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n556N6Gb033765;
Fri, 5 Jun 2009 06:23:06 GMT
(envelope-from pgollucci@repoman.freebsd.org)
Received: (from pgollucci@localhost)
by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n556N62k033764;
Fri, 5 Jun 2009 06:23:06 GMT
(envelope-from pgollucci)
Message-Id: <200906050623.n556N62k033764@repoman.freebsd.org>
From: "Philip M. Gollucci"
Date: Fri, 5 Jun 2009 06:23:06 +0000 (UTC)
To: ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org
Subject: cvs commit: ports/www/mod_perl Makefile ports/www/mod_perl/files
patch-src__modules__perl__mod_perl.c
X-FreeBSD-CVS-Branch: HEAD
Sender: owner-ports-committers@FreeBSD.org
Precedence: bulk
X-Loop: FreeBSD.ORG
X-Virus-Scanned: ClamAV 0.94.2/9425/Thu Jun 4 23:55:18 2009 on piccollo.p6m7g8.net
X-Virus-Status: Clean
X-Spam-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,
RCVD_IN_DNSWL_MED,SPF_PASS autolearn=ham version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on piccollo.p6m7g8.net

pgollucci 2009-06-05 06:23:06 UTC

FreeBSD ports repository

Modified files:
www/mod_perl Makefile
Added files:
www/mod_perl/files patch-src__modules__perl__mod_perl.c
Log:
- Fix a segfault in mod_perl startup due to a bug
in gcc related optimizations.
- Fixed upstream in branches/1.x@r781917
- Bump PORTREVISION

PR: ports/13479
Reported by: Troy
Submitted by: Tim Zingelman

Revision Changes Path
1.43 +1 -0 ports/www/mod_perl/Makefile
1.1 +19 -0 ports/www/mod_perl/files/patch-src__modules__perl__mod_perl. c (new)
http://cvsweb.FreeBSD.org/ports/www/mod_perl/files/patch-src __modules__perl__mod_perl.c?rev=1.1&content-type=text/x-cvsw eb-markup

http://cvsweb.FreeBSD.org/ports/www/mod_perl/Makefile.diff?r 1=1.42&r2=1.43&f=h
| --- ports/www/mod_perl/Makefile 2009/05/16 06:27:51 1.42
| +++ ports/www/mod_perl/Makefile 2009/06/05 06:23:06 1.43
| @@ -2,11 +2,12 @@
| # Date created: November 5th 1999
| # Whom: Sheldon Hearn
| #
| -# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/www/mod_perl/Makefile,v 1.42 2009/05/16 06:27:51 pgollucci Exp $
| +# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/www/mod_perl/Makefile,v 1.43 2009/06/05 06:23:06 pgollucci Exp $
| #
|
| PORTNAME= mod_perl
| PORTVERSION= 1.31
| +PORTREVISION= 1
| CATEGORIES= www perl5
| MASTER_SITES= CPAN
| MASTER_SITE_SUBDIR= ModPerl/GOZER

--------------090900080007060608010901--

Re: [Fwd: Re: ports/134749: www/mod_perl bus error after 1.31 update]

am 05.06.2009 19:25:40 von david

On Jun 4, 2009, at 11:26 PM, Philip M. Gollucci wrote:

> fixed....

Hrm. I wonder if it will fix [this error](http://www.mail-archive.com/dev@perl.apache.org/msg12 057.html
) as well?

Best,

David

Re: [Fwd: Re: ports/134749: www/mod_perl bus error after 1.31 update]

am 05.06.2009 20:08:15 von Philip Gollucci

David E. Wheeler wrote:
> On Jun 4, 2009, at 11:26 PM, Philip M. Gollucci wrote:
>
>> fixed....
>
> Hrm. I wonder if it will fix [this
> error](http://www.mail-archive.com/dev@perl.apache.org/msg12 057.html) as
> well?
>

It might, but I don't think its related

I can test it here
Darwin clarus.apache.org. 8.11.0 Darwin Kernel Version 8.11.0: Wed Oct 10
18:26:00 PDT 2007; root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh powerpc

whenever I get a moment unless you beat me to it, but really I wish 1.3 would die.


> Best,
>
> David


--
------------------------------------------------------------ ------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
Consultant - P6M7G8 Inc. http://p6m7g8.net
Senior Sys Admin - RideCharge, Inc. http://ridecharge.com
Contractor - PositiveEnergyUSA http://positiveenergyusa.com
ASF Member - Apache Software Foundation http://apache.org
FreeBSD Committer - FreeBSD Foundation http://freebsd.org

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.

Re: [Fwd: Re: ports/134749: www/mod_perl bus error after 1.31 update]

am 05.06.2009 20:19:57 von david

On Jun 5, 2009, at 11:08 AM, Philip M. Gollucci wrote:

> It might, but I don't think its related
>
> I can test it here
> Darwin clarus.apache.org. 8.11.0 Darwin Kernel Version 8.11.0: Wed =20
> Oct 10 18:26:00 PDT 2007; root:xnu-792.24.17~1/RELEASE_PPC Power =20
> Macintosh powerpc
>
> whenever I get a moment unless you beat me to it, but really I wish =20=

> 1.3 would die.

Oh, the bus error I reported last year was in 2.0.4=85

David=

Re: [Fwd: Re: ports/134749: www/mod_perl bus error after 1.31 update]

am 05.06.2009 20:28:09 von Philip Gollucci

David E. Wheeler wrote:
> On Jun 5, 2009, at 11:08 AM, Philip M. Gollucci wrote:
>
>> It might, but I don't think its related
>>
>> I can test it here
>> Darwin clarus.apache.org. 8.11.0 Darwin Kernel Version 8.11.0: Wed Oct
>> 10 18:26:00 PDT 2007; root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh
>> powerpc
>>
>> whenever I get a moment unless you beat me to it, but really I wish
>> 1.3 would die.
>
> Oh, the bus error I reported last year was in 2.0.4…

Well I can still try to replicate that on clarus, I didn't have access to that
before....


--
------------------------------------------------------------ ------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
Consultant - P6M7G8 Inc. http://p6m7g8.net
Senior Sys Admin - RideCharge, Inc. http://ridecharge.com
Contractor - PositiveEnergyUSA http://positiveenergyusa.com
ASF Member - Apache Software Foundation http://apache.org
FreeBSD Committer - FreeBSD Foundation http://freebsd.org

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.