navigation include not functioning

--0016364eed74642c7a047067f270
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

I am trying to generate pages by importing content in includes, and using my
navigation include to tell PHP to replace a $thisPage variable which all the
includes use

The idea behind it (I know tons of people do it, but I'm new to this
concept), is to have a 'layout' page where only a variable changes using
$_GET on an href (index.php?page=services or index.php?page=about) to load
the new 'pages'.

PROBLEM:
All my links are displaying the current page state, and links are not
building around the link text (hrefs are built conditionally with if
$thisPage != services then build the link, otherwise leave it as normal
text). Same thing with the background image behind the link text (to
indicate a page's current position). If the condition is not true, all the
links (except the true current 'page') are supposed reload index.php and
pass a variable to itself to place into $thisPage using
href="index.php?page=" (after which I have a variable which stores "about"
or "services" within the if statement near the link text.

If this sounds like something you are familiar with (former issues and
whatnot) please let me know what I'm doing wrong. I would be happy to give
you any code you want to look at (index.php or navigation.php, whatever).

Thanks again for your help PHP gurus!

--0016364eed74642c7a047067f270--

Re: navigation include not functioning

--001636458c0e25f7ff0470681523
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

I'm having trouble understanding your description of the problem. Can you
tell us what you're seeing and what you expect to see?
Jerry Wilborn
jerrywilborn@gmail.com


On Wed, Aug 5, 2009 at 12:00 PM, Allen McCabe wrote:

> I am trying to generate pages by importing content in includes, and using
> my
> navigation include to tell PHP to replace a $thisPage variable which all
> the
> includes use
>
> The idea behind it (I know tons of people do it, but I'm new to this
> concept), is to have a 'layout' page where only a variable changes using
> $_GET on an href (index.php?page=services or index.php?page=about) to load
> the new 'pages'.
>
> PROBLEM:
> All my links are displaying the current page state, and links are not
> building around the link text (hrefs are built conditionally with if
> $thisPage != services then build the link, otherwise leave it as normal
> text). Same thing with the background image behind the link text (to
> indicate a page's current position). If the condition is not true, all the
> links (except the true current 'page') are supposed reload index.php and
> pass a variable to itself to place into $thisPage using
> href="index.php?page=" (after which I have a variable which stores "about"
> or "services" within the if statement near the link text.
>
> If this sounds like something you are familiar with (former issues and
> whatnot) please let me know what I'm doing wrong. I would be happy to give
> you any code you want to look at (index.php or navigation.php, whatever).
>
> Thanks again for your help PHP gurus!
>

--001636458c0e25f7ff0470681523--

Re: navigation include not functioning

--00163646c2e2f3adb3047068323a
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Sure.

When I load my site, default.php loads ( displaying:
http://uplinkdesign.hostzi.com/ in the browser as expected). $thisPage is
set to "about" via:

if (!isset($thisPage)) {
$thisPage="about";
} else {
$thisPage = addslashes($_GET['page']);
}
?>

in the tags.


I am seeing this:

The first 2 includes work just fine, loading to proper middle section and
proper right-hand-side page content, the navigation include also loads, but
all the of "tabs" (background images) are the currentpage image, as opposed
to not, as they should be (the the exception of the About Us background
image).

It seems that $thisPage is equal to all four values, so all the if
statements within navigation tell PHP to load the current page image for all
4 links.

Does this help?
On Wed, Aug 5, 2009 at 10:10 AM, Jerry Wilborn wrote:

> I'm having trouble understanding your description of the problem. Can you
> tell us what you're seeing and what you expect to see?
> Jerry Wilborn
> jerrywilborn@gmail.com
>
>
>
> On Wed, Aug 5, 2009 at 12:00 PM, Allen McCabe wrote:
>
>> I am trying to generate pages by importing content in includes, and using
>> my
>> navigation include to tell PHP to replace a $thisPage variable which all
>> the
>> includes use
>>
>> The idea behind it (I know tons of people do it, but I'm new to this
>> concept), is to have a 'layout' page where only a variable changes using
>> $_GET on an href (index.php?page=services or index.php?page=about) to load
>> the new 'pages'.
>>
>> PROBLEM:
>> All my links are displaying the current page state, and links are not
>> building around the link text (hrefs are built conditionally with if
>> $thisPage != services then build the link, otherwise leave it as normal
>> text). Same thing with the background image behind the link text (to
>> indicate a page's current position). If the condition is not true, all the
>> links (except the true current 'page') are supposed reload index.php and
>> pass a variable to itself to place into $thisPage using
>> href="index.php?page=" (after which I have a variable which stores "about"
>> or "services" within the if statement near the link text.
>>
>> If this sounds like something you are familiar with (former issues and
>> whatnot) please let me know what I'm doing wrong. I would be happy to give
>> you any code you want to look at (index.php or navigation.php, whatever).
>>
>> Thanks again for your help PHP gurus!
>>
>
>

--00163646c2e2f3adb3047068323a--

Re: navigation include not functioning

I think you are looking for something like this:

$page =3D array_key_exists( 'page', $_GET ) ? GET['page'] : 'index';

Then you MUST sanitize the $page variable.

I often use the querystring to wrapp the module you are requesting:

www.example.org/?path/to/molude (note that .htaccess is required)

# the you can access by
echo $path =3D $_SERVER['QUERY_STRING'];

On Wed, Aug 5, 2009 at 2:19 PM, Allen McCabe wrote:
> Sure.
>
> When I load my site, default.php loads ( displaying:
> http://uplinkdesign.hostzi.com/ in the browser as expected). $thisPage is
> set to "about" via:
>
> > if (!isset($thisPage)) {
> =A0$thisPage=3D"about";
> =A0} else {
> =A0$thisPage =3D addslashes($_GET['page']);
> =A0}
> ?>
>
> in the tags.
>
>
> I am seeing this:
>
> The first 2 includes work just fine, loading to proper middle section and
> proper right-hand-side page content, the navigation include also loads, b=
ut
> all the of "tabs" (background images) are the currentpage image, as oppos=
ed
> to not, as they should be (the the exception of the About Us background
> image).
>
> It seems that $thisPage is equal to all four values, so all the if
> statements within navigation tell PHP to load the current page image for =
all
> 4 links.
>
> Does this help?
> On Wed, Aug 5, 2009 at 10:10 AM, Jerry Wilborn wr=
ote:
>
>> I'm having trouble understanding your description of the problem. =A0Can=
you
>> tell us what you're seeing and what you expect to see?
>> Jerry Wilborn
>> jerrywilborn@gmail.com
>>
>>
>>
>> On Wed, Aug 5, 2009 at 12:00 PM, Allen McCabe wro=
te:
>>
>>> I am trying to generate pages by importing content in includes, and usi=
ng
>>> my
>>> navigation include to tell PHP to replace a $thisPage variable which al=
l
>>> the
>>> includes use
>>>
>>> The idea behind it (I know tons of people do it, but I'm new to this
>>> concept), is to have a 'layout' page where only a variable changes usin=
g
>>> $_GET on an href (index.php?page=3Dservices or index.php?page=3Dabout) =
to load
>>> the new 'pages'.
>>>
>>> PROBLEM:
>>> All my links are displaying the current page state, and links are not
>>> building around the link text (hrefs are built conditionally with if
>>> $thisPage !=3D services then build the link, otherwise leave it as norm=
al
>>> text). Same thing with the background image behind the link text (to
>>> indicate a page's current position). If the condition is not true, all =
the
>>> links (except the true current 'page') are supposed reload index.php an=
d
>>> pass a variable to itself to place into $thisPage using
>>> href=3D"index.php?page=3D" (after which I have a variable which stores =
"about"
>>> or "services" within the if statement near the link text.
>>>
>>> If this sounds like something you are familiar with (former issues and
>>> whatnot) please let me know what I'm doing wrong. I would be happy to g=
ive
>>> you any code you want to look at (index.php or navigation.php, whatever=
).
>>>
>>> Thanks again for your help PHP gurus!
>>>
>>
>>
>



--=20
Martin Scotta

--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: navigation include not functioning

On Wed, 05 Aug 2009 20:19:00 +0300, Allen McCabe
wrote:

> Sure.
>
> When I load my site, default.php loads ( displaying:
> http://uplinkdesign.hostzi.com/ in the browser as expected). $thisPage is
> set to "about" via:
>
> > if (!isset($thisPage)) {
> $thisPage="about";
> } else {
> $thisPage = addslashes($_GET['page']);
> }
> ?>
>
> in the tags.
>
>
> I am seeing this:
>
> The first 2 includes work just fine, loading to proper middle section and
> proper right-hand-side page content, the navigation include also loads,
> but
> all the of "tabs" (background images) are the currentpage image, as
> opposed
> to not, as they should be (the the exception of the About Us background
> image).
>
> It seems that $thisPage is equal to all four values, so all the if
> statements within navigation tell PHP to load the current page image for
> all
> 4 links.
>
> Does this help?

Looks like you need something like that:
$pages = array(
// list of modules you have, for example:
'about' , 'help', etc
);
$page = isset($_GET['page']) && isset($pages[$_GET['page']]) ?
$_GET['page'] : 'about';
// about is default page here

then just:
include 'modules/'.$page.'.php';

Always remember that you have to check what is included.
Best approach(if possible) to have a predefined list of all modules which
can be included.

Else, there is some nasty things like:
?page=../index.php
(infinity recurssion)

?page=http://otherhost.com/hacker.
(inclusion of malicious script)
and so on.




> On Wed, Aug 5, 2009 at 10:10 AM, Jerry Wilborn
> wrote:
>
Look

>> I'm having trouble understanding your description of the problem. Can
>> you
>> tell us what you're seeing and what you expect to see?
>> Jerry Wilborn
>> jerrywilborn@gmail.com
>>
>>
>>
>> On Wed, Aug 5, 2009 at 12:00 PM, Allen McCabe
>> wrote:
>>
>>> I am trying to generate pages by importing content in includes, and
>>> using
>>> my
>>> navigation include to tell PHP to replace a $thisPage variable which
>>> all
>>> the
>>> includes use
>>>
>>> The idea behind it (I know tons of people do it, but I'm new to this
>>> concept), is to have a 'layout' page where only a variable changes
>>> using
>>> $_GET on an href (index.php?page=services or index.php?page=about) to
>>> load
>>> the new 'pages'.
>>>
>>> PROBLEM:
>>> All my links are displaying the current page state, and links are not
>>> building around the link text (hrefs are built conditionally with if
>>> $thisPage != services then build the link, otherwise leave it as normal
>>> text). Same thing with the background image behind the link text (to
>>> indicate a page's current position). If the condition is not true, all
>>> the
>>> links (except the true current 'page') are supposed reload index.php
>>> and
>>> pass a variable to itself to place into $thisPage using
>>> href="index.php?page=" (after which I have a variable which stores
>>> "about"
>>> or "services" within the if statement near the link text.
>>>
>>> If this sounds like something you are familiar with (former issues and
>>> whatnot) please let me know what I'm doing wrong. I would be happy to
>>> give
>>> you any code you want to look at (index.php or navigation.php,
>>> whatever).
>>>
>>> Thanks again for your help PHP gurus!
>>>
>>
>>
>
>



--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: navigation include not functioning

--00163646c2e231480904706af401
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Okay, I see how href="?page=contact" would work, and I do indeed have only
one file (which loads includes), but it still is not working. Clicking a
link, be href=?page=contact, href=?page=services, whatever, it still loads
the page with the ?page=whatever attached to the URL, but it is not
subsituting the $page variable within the include snippets, and it just
loads the 'about' versions of all includes (/phpincludes/about_content.php
as opposed to /phpincludes/services_content.php or whichever).

This is really stumping me and try as I might I cannot see why it will not
work. Here is some of my code as it is currently:

On default.php:

[code=default.php]




$pages = array(
// list of includes:
'about' , 'services', 'portfolio', 'contact'
);
$page = isset($_GET['page']) && isset($pages[$_GET['page']]) ?
$_GET['page'] : 'about';
// about is default page here

?>