Write and Submit Your First Kernel Patch

Hi,

Just before I send my patch I got this error with:
../scripts/checkpatch.pl --terse --file
0001-Staging-comedi-driver-fix-coding-style.patch

0001-Staging-comedi-driver-fix-coding-style.patch:27: ERROR: trailing whitespace
0001-Staging-comedi-driver-fix-coding-style.patch:35: ERROR: trailing whitespace
0001-Staging-comedi-driver-fix-coding-style.patch:43: ERROR: trailing whitespace
0001-Staging-comedi-driver-fix-coding-style.patch:53: ERROR: trailing whitespace

I have done a step by step explanation of what I have done:
http://kapare.blogspot.com/2009/09/write-and-submit-your-fir st-kernel.html

It seem to me that the whitespace are added after I do this command:
git format-patch -s -n master..mybranch

Can someone help me with that because google did help me to found the answer?

Thx

kap

Re: Write and Submit Your First Kernel Patch

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

>> Kevyn-Alexandre Paré writes:
>>> 0001-Staging-comedi-driver-fix-coding-style.patch:27: ERROR: trailing w=
hitespace
>>> 0001-Staging-comedi-driver-fix-coding-style.patch:35: ERROR: trailing w=
hitespace
>>> 0001-Staging-comedi-driver-fix-coding-style.patch:43: ERROR: trailing w=
hitespace
>>> 0001-Staging-comedi-driver-fix-coding-style.patch:53: ERROR: trailing w=
hitespace
>>>
>>> I have done a step by step explanation of what I have done:
>>> http://kapare.blogspot.com/2009/09/write-and-submit-your-fir st-kernel.h=
tml>>
>>> It seem to me that the whitespace are added after I do this command:
>>> git format-patch -s -n master..mybranch

> On Fri, Oct 23, 2009 at 3:13 PM, Michal Nazarewicz wrote:
>> Do "git rebase --whitespace=3Dfix master" and git will try to fix whites=
paces.

Kevyn-Alexandre Paré writes:
> thx Michal,
>
> But the problem remain:

If I'm not mistaken "git rebase --whitespace=3Dfix master" should do the
trick. I'm out of good ideas if it does not. Best I can advice is to
fix the patch by hand -- just edit it in some decent editor and remove
trailing whitespaces from those lines.

=2D-=20
Best regards, _ _
.o. | Liege of Serenly Enlightened Majesty of o' \,=3D./ `o
..o | Computer Science, Michal "mina86" Nazarewicz (o o)
ooo +------ooO--(_)--Ooo--

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (GNU/Linux)

iEYEARECAAYFAkriBvEACgkQUyzLALfG3x535wCfXiB4Rz1/uNltpt4jPUd2 fn8c
aAoAnAhCF4je11wA2ABlNjfxYkiwsqwO
=0e6t
-----END PGP SIGNATURE-----
--=-=-=--

Re: Write and Submit Your First Kernel Patch

Kevyn-Alexandre Paré writes:

> Just before I send my patch I got this error with:
> ./scripts/checkpatch.pl --terse --file
> 0001-Staging-comedi-driver-fix-coding-style.patch
>
> 0001-Staging-comedi-driver-fix-coding-style.patch:27: ERROR: trailing=
whitespace
> 0001-Staging-comedi-driver-fix-coding-style.patch:35: ERROR: trailing=
whitespace
> 0001-Staging-comedi-driver-fix-coding-style.patch:43: ERROR: trailing=
whitespace
> 0001-Staging-comedi-driver-fix-coding-style.patch:53: ERROR: trailing=
whitespace
>
> I have done a step by step explanation of what I have done:
> http://kapare.blogspot.com/2009/09/write-and-submit-your-fir st-kernel=
html
>
> It seem to me that the whitespace are added after I do this command:
> git format-patch -s -n master..mybranch

"The whitespace are added after..." sounds to me that what you committe=
d
were checkpatch compliant, and format-patch somehow broke it. If that =
is
the case we need to fix format-patch.

Please check if "git show $commit" output for the commit that correspon=
ds
to the "[Staging] comedi driver: fix coding style" patch has trailing
whitespaces. That is what you committed.

If there already is whitespace breakage in what you committed, then we =
do
not have to blame format-patch and look for bugs in it to fix.

Otherwise, please send 0001-*.patch (output from format-patch) and outp=
ut
from that "git show $commit" as separate attachments, so that we can de=
bug
and fix format-patch.

Thanks.

Re: Write and Submit Your First Kernel Patch

--001636d33c7cfaf8cb0476a014b5
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Thx junio for that analyse!

So what I understand from what you have said is that the problem is
not in format-patch since that I see white space from git show $commit
?!:

history: I was trying to remove coding style problem in
drivers/staging/comedi/drivers/pcl726.c

../scripts/checkpatch.pl --terse --file
drivers/staging/comedi/drivers/pcl726.c #### NO warning after
removing problems
### git commit -a
# was done after that
### git format-patch -s -n master..pcl726

kapare@vostro:~/linux-kernel-patch/linux-2.6$ git show $commit >
TEST.git.show.commit #### see whitespace in vim
kapare@vostro:~/linux-kernel-patch/linux-2.6$ ./scripts/checkpatch.pl
--terse --file TEST.git.show.commit
TEST:19: ERROR: trailing whitespace
TEST:27: ERROR: trailing whitespace
TEST:35: ERROR: trailing whitespace
TEST:45: ERROR: trailing whitespace
TEST:55: ERROR: trailing whitespace
TEST:60: ERROR: trailing whitespace
TEST:67: ERROR: trailing whitespace
TEST:69: ERROR: trailing whitespace
TEST:80: ERROR: trailing whitespace
TEST:106: ERROR: trailing whitespace
TEST:113: ERROR: trailing whitespace

So what am I doing wrong? Any clues? see attachment you ask

thx

kap

On Fri, Oct 23, 2009 at 3:52 PM, Junio C Hamano wrote:
> Kevyn-Alexandre Par=E9 =A0 writes:
>
>> Just before I send my patch I got this error with:
>> ./scripts/checkpatch.pl --terse --file
>> 0001-Staging-comedi-driver-fix-coding-style.patch
>>
>> 0001-Staging-comedi-driver-fix-coding-style.patch:27: ERROR: trailing wh=
itespace
>> 0001-Staging-comedi-driver-fix-coding-style.patch:35: ERROR: trailing wh=
itespace
>> 0001-Staging-comedi-driver-fix-coding-style.patch:43: ERROR: trailing wh=
itespace
>> 0001-Staging-comedi-driver-fix-coding-style.patch:53: ERROR: trailing wh=
itespace
>>
>> I have done a step by step explanation of what I have done:
>> http://kapare.blogspot.com/2009/09/write-and-submit-your-fir st-kernel.ht=
ml
>>
>> It seem to me that the whitespace are added after I do this command:
>> git format-patch -s -n master..mybranch
>
> "The whitespace are added after..." sounds to me that what you committed
> were checkpatch compliant, and format-patch somehow broke it. =A0If that =
is
> the case we need to fix format-patch.
>
> Please check if "git show $commit" output for the commit that corresponds
> to the "[Staging] comedi driver: fix coding style" patch has trailing
> whitespaces. =A0That is what you committed.
>
> If there already is whitespace breakage in what you committed, then we do
> not have to blame format-patch and look for bugs in it to fix.
>
> Otherwise, please send 0001-*.patch (output from format-patch) and output
> from that "git show $commit" as separate attachments, so that we can debu=
g
> and fix format-patch.
>
> Thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-newbie" i=
n
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at =A0http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.linux-learn.org/faqs
>

--001636d33c7cfaf8cb0476a014b5
Content-Type: text/x-patch; charset=UTF-8;
name="0001-Staging-comedi-driver-fix-coding-style.patch"
Content-Disposition: attachment;
filename="0001-Staging-comedi-driver-fix-coding-style.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g15dl2uq0

RnJvbSAyMzEzMjcwMDY4NTgxZmY0MjUxNDBjMWYzNjFiMjZlZGQwOTY2NThm IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiA9P3V0Zi04P3E/S2V2eW4tQWxleGFuZHJl PTIwUGFyPUMzPUE5
Pz0gPGtldnluLmFsZXhhbmRyZS5wYXJlQGdtYWlsLmNvbT4KRGF0ZTogRnJp LCAyMyBPY3QgMjAw
OSAwMDo1OTo0MCAtMDQwMApTdWJqZWN0OiBbUEFUQ0ggMS8xXSBTdGFnaW5n OiBjb21lZGkgZHJp
dmVyOiBmaXggY29kaW5nIHN0eWxlCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRl bnQtVHlwZTogdGV4
dC9wbGFpbjsgY2hhcnNldD11dGYtOApDb250ZW50LVRyYW5zZmVyLUVuY29k aW5nOiA4Yml0CgoK
U2lnbmVkLW9mZi1ieTogS2V2eW4tQWxleGFuZHJlIFBhcsOpIDxrZXZ5bi5h bGV4YW5kcmUucGFy
ZUBnbWFpbC5jb20+Ci0tLQogZHJpdmVycy9zdGFnaW5nL2NvbWVkaS9kcml2 ZXJzL3BjbDcyNi5j
IHwgICA0MSArKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCiAxIGZp bGVzIGNoYW5nZWQs
IDIwIGluc2VydGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL2RyaXZlcnMv
c3RhZ2luZy9jb21lZGkvZHJpdmVycy9wY2w3MjYuYyBiL2RyaXZlcnMvc3Rh Z2luZy9jb21lZGkv
ZHJpdmVycy9wY2w3MjYuYwppbmRleCBjY2FkZDA5Li42MjA4YmNhIDEwMDY0 NAotLS0gYS9kcml2
ZXJzL3N0YWdpbmcvY29tZWRpL2RyaXZlcnMvcGNsNzI2LmMKKysrIGIvZHJp dmVycy9zdGFnaW5n
L2NvbWVkaS9kcml2ZXJzL3BjbDcyNi5jCkBAIC0zOSwyNyArMzksMjcgQEAg SW50ZXJydXB0cyBh
cmUgbm90IHN1cHBvcnRlZC4KICAgICBPcHRpb25zIGZvciBQQ0wtNzI2Ogog ICAgICBbMF0gLSBJ
TyBCYXNlCiAgICAgIFsyXS4uLls3XSAtIEQvQSBvdXRwdXQgcmFuZ2UgZm9y IGNoYW5uZWwgMS02
OgotICAgICAgICAgICAgICAgMDogMC01ViwgMTogMC0xMFYsIDI6ICsvLTVW LCAzOiArLy0xMFYs
Ci0JICAgICAgIDQ6IDQtMjBtQSwgNTogdW5rbm93biAoZXh0ZXJuYWwgcmVm ZXJlbmNlKQorCQkw
OiAwLTVWLCAxOiAwLTEwViwgMjogKy8tNVYsIDM6ICsvLTEwViwKKwkJNDog NC0yMG1BLCA1OiB1
bmtub3duIChleHRlcm5hbCByZWZlcmVuY2UpCiAKICAgICBPcHRpb25zIGZv ciBQQ0wtNzI3Ogog
ICAgICBbMF0gLSBJTyBCYXNlCiAgICAgIFsyXS4uLlsxM10gLSBEL0Egb3V0 cHV0IHJhbmdlIGZv
ciBjaGFubmVsIDEtMTI6Ci0gICAgICAgICAgICAgICAwOiAwLTVWLCAxOiAw LTEwViwgMjogKy8t
NVYsCi0JICAgICAgIDM6IDQtMjBtQQorCQkwOiAwLTVWLCAxOiAwLTEwViwg MjogKy8tNVYsCisJ
CTM6IDQtMjBtQQogCiAgICAgT3B0aW9ucyBmb3IgUENMLTcyOCBhbmQgQUNM LTYxMjg6CiAgICAg
IFswXSAtIElPIEJhc2UKICAgICAgWzJdLCBbM10gLSBEL0Egb3V0cHV0IHJh bmdlIGZvciBjaGFu
bmVsIDEgYW5kIDI6Ci0gICAgICAgICAgICAgICAwOiAwLTVWLCAxOiAwLTEw ViwgMjogKy8tNVYs
IDM6ICsvLTEwViwKLQkgICAgICAgNDogNC0yMG1BLCA1OiAwLTIwbUEKKwkJ MDogMC01ViwgMTog
MC0xMFYsIDI6ICsvLTVWLCAzOiArLy0xMFYsCisJCTQ6IDQtMjBtQSwgNTog MC0yMG1BCiAKICAg
ICBPcHRpb25zIGZvciBBQ0wtNjEyNjoKICAgICAgWzBdIC0gSU8gQmFzZQog ICAgICBbMV0gLSBJ
UlEgKDA9ZGlzYWJsZSwgMywgNSwgNiwgNywgOSwgMTAsIDExLCAxMiwgMTUp IChjdXJyZW50bHkg
aWdub3JlZCkKICAgICAgWzJdLi4uWzddIC0gRC9BIG91dHB1dCByYW5nZSBm b3IgY2hhbm5lbCAx
LTY6Ci0gICAgICAgICAgICAgICAwOiAwLTVWLCAxOiAwLTEwViwgMjogKy8t NVYsIDM6ICsvLTEw
ViwKLQkgICAgICAgNDogNC0yMG1BCisJCTA6IDAtNVYsIDE6IDAtMTBWLCAy OiArLy01ViwgMzog
Ky8tMTBWLAorCQk0OiA0LTIwbUEKICovCiAKIC8qCkBAIC0xMjcsNyArMTI3 LDggQEAgc3RydWN0
IHBjbDcyNl9ib2FyZCB7CiAJaW50IGRpX2xvOwogCWludCBkb19oaTsKIAlp bnQgZG9fbG87Ci0J
Y29uc3Qgc3RydWN0IGNvbWVkaV9scmFuZ2UgKmNvbnN0ICpyYW5nZV90eXBl X2xpc3Q7CS8qICBs
aXN0IG9mIHN1cHBvcnRlZCByYW5nZXMgKi8KKwljb25zdCBzdHJ1Y3QgY29t ZWRpX2xyYW5nZSAq
Y29uc3QgKnJhbmdlX3R5cGVfbGlzdDsKKwkvKiAgbGlzdCBvZiBzdXBwb3J0 ZWQgcmFuZ2VzICov
CiB9OwogCiBzdGF0aWMgY29uc3Qgc3RydWN0IHBjbDcyNl9ib2FyZCBib2Fy ZHR5cGVzW10gPSB7
CkBAIC0yMDQsOSArMjA1LDggQEAgc3RhdGljIGludCBwY2w3MjZfYW9faW5z bl9yZWFkKHN0cnVj
dCBjb21lZGlfZGV2aWNlICpkZXYsCiAJaW50IGNoYW4gPSBDUl9DSEFOKGlu c24tPmNoYW5zcGVj
KTsKIAlpbnQgbjsKIAotCWZvciAobiA9IDA7IG4gPCBpbnNuLT5uOyBuKysp IHsKKwlmb3IgKG4g
PSAwOyBuIDwgaW5zbi0+bjsgbisrKQogCQlkYXRhW25dID0gZGV2cHJpdi0+ YW9fcmVhZGJhY2tb
Y2hhbl07Ci0JfQogCXJldHVybiBuOwogfQogCkBAIC0yNTYsMTAgKzI1Niwx MCBAQCBzdGF0aWMg
aW50IHBjbDcyNl9hdHRhY2goc3RydWN0IGNvbWVkaV9kZXZpY2UgKmRldiwg c3RydWN0IGNvbWVk
aV9kZXZjb25maWcgKml0KQogCiAJaW9iYXNlID0gaXQtPm9wdGlvbnNbMF07 CiAJaW9yYW5nZSA9
IHRoaXNfYm9hcmQtPmlvX3JhbmdlOwotCXByaW50aygiY29tZWRpJWQ6IHBj bDcyNjogYm9hcmQ9
JXMsIDB4JTAzbHggIiwgZGV2LT5taW5vciwKKwlwcmludGsoS0VSTl9XQVJO SU5HLCAiY29tZWRp
JWQ6IHBjbDcyNjogYm9hcmQ9JXMsIDB4JTAzbHggIiwgZGV2LT5taW5vciwK IAkgICAgICAgdGhp
c19ib2FyZC0+bmFtZSwgaW9iYXNlKTsKIAlpZiAoIXJlcXVlc3RfcmVnaW9u KGlvYmFzZSwgaW9y
YW5nZSwgInBjbDcyNiIpKSB7Ci0JCXByaW50aygiSS9PIHBvcnQgY29uZmxp Y3RcbiIpOworCQlw
cmludGsoS0VSTl9XQVJOSU5HLCAiSS9PIHBvcnQgY29uZmxpY3RcbiIpOwog CQlyZXR1cm4gLUVJ
TzsKIAl9CiAKQEAgLTI4MywxNiArMjgzLDE2IEBAIHN0YXRpYyBpbnQgcGNs NzI2X2F0dGFjaChz
dHJ1Y3QgY29tZWRpX2RldmljZSAqZGV2LCBzdHJ1Y3QgY29tZWRpX2RldmNv bmZpZyAqaXQpCiAJ
CWRldnByaXYtPmZpcnN0X2NoYW4gPSAyOwogCQlpZiAoaXJxKSB7CS8qIHdl IHdhbnQgdG8gdXNl
IElSUSAqLwogCQkJaWYgKCgoMSA8PCBpcnEpICYgYm9hcmR0eXBlc1tib2Fy ZF0uSVJRYml0cykg
PT0gMCkgewotCQkJCXByaW50awotCQkJCSAgICAoIiwgSVJRICVkIGlzIG91 dCBvZiBhbGxvd2Vk
IHJhbmdlLCBESVNBQkxJTkcgSVQiLAotCQkJCSAgICAgaXJxKTsKKwkJCQlw cmludGsoS0VSTl9X
QVJOSU5HLAorCQkJCQkiLCBJUlEgJWQgaXMgb3V0IG9mIGFsbG93ZWQgcmFu Z2UsIgorCQkJCQki
IERJU0FCTElORyBJVCIsIGlycSk7CiAJCQkJaXJxID0gMDsJLyogQmFkIElS USAqLwogCQkJfSBl
bHNlIHsKIAkJCQlpZiAocmVxdWVzdF9pcnEoaXJxLCBpbnRlcnJ1cHRfcGNs ODE4LCAwLAogCQkJ
CQkJInBjbDcyNiIsIGRldikpIHsKLQkJCQkJcHJpbnRrCi0JCQkJCSAgICAo IiwgdW5hYmxlIHRv
IGFsbG9jYXRlIElSUSAlZCwgRElTQUJMSU5HIElUIiwKLQkJCQkJICAgICBp cnEpOworCQkJCQlw
cmludGsoS0VSTl9XQVJOSU5HLAorCQkJCQkJIiwgdW5hYmxlIHRvIGFsbG9j YXRlIElSUSAlZCwi
CisJCQkJCQkiIERJU0FCTElORyBJVCIsIGlycSk7CiAJCQkJCWlycSA9IDA7 CS8qIENhbid0IHVz
ZSBJUlEgKi8KIAkJCQl9IGVsc2UgewogCQkJCQlwcmludGsoIiwgaXJxPSVk IiwgaXJxKTsKQEAg
LTM3Miw5ICszNzIsOCBAQCBzdGF0aWMgaW50IHBjbDcyNl9kZXRhY2goc3Ry dWN0IGNvbWVkaV9k
ZXZpY2UgKmRldikKIC8qIHByaW50aygiY29tZWRpJWQ6IHBjbDcyNjogcmVt b3ZlXG4iLGRldi0+
bWlub3IpOyAqLwogCiAjaWZkZWYgQUNMNjEyNl9JUlEKLQlpZiAoZGV2LT5p cnEpIHsKKwlpZiAo
ZGV2LT5pcnEpCiAJCWZyZWVfaXJxKGRldi0+aXJxLCBkZXYpOwotCX0KICNl bmRpZgogCiAJaWYg
KGRldi0+aW9iYXNlKQotLSAKMS42LjAuNAoK
--001636d33c7cfaf8cb0476a014b5
Content-Type: application/octet-stream; name="TEST.git.show.commit"
Content-Disposition: attachment; filename="TEST.git.show.commit"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g15dlj451

Y29tbWl0IDIzMTMyNzAwNjg1ODFmZjQyNTE0MGMxZjM2MWIyNmVkZDA5NjY1 OGYKQXV0aG9yOiBL
ZXZ5bi1BbGV4YW5kcmUgUGFyw6kgPGtldnluLmFsZXhhbmRyZS5wYXJlQGdt YWlsLmNvbT4KRGF0
ZTogICBGcmkgT2N0IDIzIDAwOjU5OjQwIDIwMDkgLTA0MDAKCiAgICBTdGFn aW5nOiBjb21lZGkg
ZHJpdmVyOiBmaXggY29kaW5nIHN0eWxlCgpkaWZmIC0tZ2l0IGEvZHJpdmVy cy9zdGFnaW5nL2Nv
bWVkaS9kcml2ZXJzL3BjbDcyNi5jIGIvZHJpdmVycy9zdGFnaW5nL2NvbWVk aS9kcml2ZXJzL3Bj
bDcyNi5jCmluZGV4IGNjYWRkMDkuLjYyMDhiY2EgMTAwNjQ0Ci0tLSBhL2Ry aXZlcnMvc3RhZ2lu
Zy9jb21lZGkvZHJpdmVycy9wY2w3MjYuYworKysgYi9kcml2ZXJzL3N0YWdp bmcvY29tZWRpL2Ry
aXZlcnMvcGNsNzI2LmMKQEAgLTM5LDI3ICszOSwyNyBAQCBJbnRlcnJ1cHRz IGFyZSBub3Qgc3Vw
cG9ydGVkLgogICAgIE9wdGlvbnMgZm9yIFBDTC03MjY6CiAgICAgIFswXSAt IElPIEJhc2UKICAg
ICAgWzJdLi4uWzddIC0gRC9BIG91dHB1dCByYW5nZSBmb3IgY2hhbm5lbCAx LTY6Ci0gICAgICAg
ICAgICAgICAwOiAwLTVWLCAxOiAwLTEwViwgMjogKy8tNVYsIDM6ICsvLTEw ViwKLQkgICAgICAg
NDogNC0yMG1BLCA1OiB1bmtub3duIChleHRlcm5hbCByZWZlcmVuY2UpCisJ CTA6IDAtNVYsIDE6
IDAtMTBWLCAyOiArLy01ViwgMzogKy8tMTBWLAorCQk0OiA0LTIwbUEsIDU6 IHVua25vd24gKGV4
dGVybmFsIHJlZmVyZW5jZSkKIAogICAgIE9wdGlvbnMgZm9yIFBDTC03Mjc6 CiAgICAgIFswXSAt
IElPIEJhc2UKICAgICAgWzJdLi4uWzEzXSAtIEQvQSBvdXRwdXQgcmFuZ2Ug Zm9yIGNoYW5uZWwg
MS0xMjoKLSAgICAgICAgICAgICAgIDA6IDAtNVYsIDE6IDAtMTBWLCAyOiAr Ly01ViwKLQkgICAg
ICAgMzogNC0yMG1BCisJCTA6IDAtNVYsIDE6IDAtMTBWLCAyOiArLy01ViwK KwkJMzogNC0yMG1B
CiAKICAgICBPcHRpb25zIGZvciBQQ0wtNzI4IGFuZCBBQ0wtNjEyODoKICAg ICAgWzBdIC0gSU8g
QmFzZQogICAgICBbMl0sIFszXSAtIEQvQSBvdXRwdXQgcmFuZ2UgZm9yIGNo YW5uZWwgMSBhbmQg
MjoKLSAgICAgICAgICAgICAgIDA6IDAtNVYsIDE6IDAtMTBWLCAyOiArLy01 ViwgMzogKy8tMTBW
LAotCSAgICAgICA0OiA0LTIwbUEsIDU6IDAtMjBtQQorCQkwOiAwLTVWLCAx OiAwLTEwViwgMjog
Ky8tNVYsIDM6ICsvLTEwViwKKwkJNDogNC0yMG1BLCA1OiAwLTIwbUEKIAog ICAgIE9wdGlvbnMg
Zm9yIEFDTC02MTI2OgogICAgICBbMF0gLSBJTyBCYXNlCiAgICAgIFsxXSAt IElSUSAoMD1kaXNh
YmxlLCAzLCA1LCA2LCA3LCA5LCAxMCwgMTEsIDEyLCAxNSkgKGN1cnJlbnRs eSBpZ25vcmVkKQog
ICAgICBbMl0uLi5bN10gLSBEL0Egb3V0cHV0IHJhbmdlIGZvciBjaGFubmVs IDEtNjoKLSAgICAg
ICAgICAgICAgIDA6IDAtNVYsIDE6IDAtMTBWLCAyOiArLy01ViwgMzogKy8t MTBWLAotCSAgICAg
ICA0OiA0LTIwbUEKKwkJMDogMC01ViwgMTogMC0xMFYsIDI6ICsvLTVWLCAz OiArLy0xMFYsCisJ
CTQ6IDQtMjBtQQogKi8KIAogLyoKQEAgLTEyNyw3ICsxMjcsOCBAQCBzdHJ1 Y3QgcGNsNzI2X2Jv
YXJkIHsKIAlpbnQgZGlfbG87CiAJaW50IGRvX2hpOwogCWludCBkb19sbzsK LQljb25zdCBzdHJ1
Y3QgY29tZWRpX2xyYW5nZSAqY29uc3QgKnJhbmdlX3R5cGVfbGlzdDsJLyog IGxpc3Qgb2Ygc3Vw
cG9ydGVkIHJhbmdlcyAqLworCWNvbnN0IHN0cnVjdCBjb21lZGlfbHJhbmdl ICpjb25zdCAqcmFu
Z2VfdHlwZV9saXN0OworCS8qICBsaXN0IG9mIHN1cHBvcnRlZCByYW5nZXMg Ki8KIH07CiAKIHN0
YXRpYyBjb25zdCBzdHJ1Y3QgcGNsNzI2X2JvYXJkIGJvYXJkdHlwZXNbXSA9 IHsKQEAgLTIwNCw5
ICsyMDUsOCBAQCBzdGF0aWMgaW50IHBjbDcyNl9hb19pbnNuX3JlYWQoc3Ry dWN0IGNvbWVkaV9k
ZXZpY2UgKmRldiwKIAlpbnQgY2hhbiA9IENSX0NIQU4oaW5zbi0+Y2hhbnNw ZWMpOwogCWludCBu
OwogCi0JZm9yIChuID0gMDsgbiA8IGluc24tPm47IG4rKykgeworCWZvciAo biA9IDA7IG4gPCBp
bnNuLT5uOyBuKyspCiAJCWRhdGFbbl0gPSBkZXZwcml2LT5hb19yZWFkYmFj a1tjaGFuXTsKLQl9
CiAJcmV0dXJuIG47CiB9CiAKQEAgLTI1NiwxMCArMjU2LDEwIEBAIHN0YXRp YyBpbnQgcGNsNzI2
X2F0dGFjaChzdHJ1Y3QgY29tZWRpX2RldmljZSAqZGV2LCBzdHJ1Y3QgY29t ZWRpX2RldmNvbmZp
ZyAqaXQpCiAKIAlpb2Jhc2UgPSBpdC0+b3B0aW9uc1swXTsKIAlpb3Jhbmdl ID0gdGhpc19ib2Fy
ZC0+aW9fcmFuZ2U7Ci0JcHJpbnRrKCJjb21lZGklZDogcGNsNzI2OiBib2Fy ZD0lcywgMHglMDNs
eCAiLCBkZXYtPm1pbm9yLAorCXByaW50ayhLRVJOX1dBUk5JTkcsICJjb21l ZGklZDogcGNsNzI2
OiBib2FyZD0lcywgMHglMDNseCAiLCBkZXYtPm1pbm9yLAogCSAgICAgICB0 aGlzX2JvYXJkLT5u
YW1lLCBpb2Jhc2UpOwogCWlmICghcmVxdWVzdF9yZWdpb24oaW9iYXNlLCBp b3JhbmdlLCAicGNs
NzI2IikpIHsKLQkJcHJpbnRrKCJJL08gcG9ydCBjb25mbGljdFxuIik7CisJ CXByaW50ayhLRVJO
X1dBUk5JTkcsICJJL08gcG9ydCBjb25mbGljdFxuIik7CiAJCXJldHVybiAt RUlPOwogCX0KIApA
QCAtMjgzLDE2ICsyODMsMTYgQEAgc3RhdGljIGludCBwY2w3MjZfYXR0YWNo KHN0cnVjdCBjb21l
ZGlfZGV2aWNlICpkZXYsIHN0cnVjdCBjb21lZGlfZGV2Y29uZmlnICppdCkK IAkJZGV2cHJpdi0+
Zmlyc3RfY2hhbiA9IDI7CiAJCWlmIChpcnEpIHsJLyogd2Ugd2FudCB0byB1 c2UgSVJRICovCiAJ
CQlpZiAoKCgxIDw8IGlycSkgJiBib2FyZHR5cGVzW2JvYXJkXS5JUlFiaXRz KSA9PSAwKSB7Ci0J
CQkJcHJpbnRrCi0JCQkJICAgICgiLCBJUlEgJWQgaXMgb3V0IG9mIGFsbG93 ZWQgcmFuZ2UsIERJ
U0FCTElORyBJVCIsCi0JCQkJICAgICBpcnEpOworCQkJCXByaW50ayhLRVJO X1dBUk5JTkcsCisJ
CQkJCSIsIElSUSAlZCBpcyBvdXQgb2YgYWxsb3dlZCByYW5nZSwiCisJCQkJ CSIgRElTQUJMSU5H
IElUIiwgaXJxKTsKIAkJCQlpcnEgPSAwOwkvKiBCYWQgSVJRICovCiAJCQl9 IGVsc2UgewogCQkJ
CWlmIChyZXF1ZXN0X2lycShpcnEsIGludGVycnVwdF9wY2w4MTgsIDAsCiAJ CQkJCQkicGNsNzI2
IiwgZGV2KSkgewotCQkJCQlwcmludGsKLQkJCQkJICAgICgiLCB1bmFibGUg dG8gYWxsb2NhdGUg
SVJRICVkLCBESVNBQkxJTkcgSVQiLAotCQkJCQkgICAgIGlycSk7CisJCQkJ CXByaW50ayhLRVJO
X1dBUk5JTkcsCisJCQkJCQkiLCB1bmFibGUgdG8gYWxsb2NhdGUgSVJRICVk LCIKKwkJCQkJCSIg
RElTQUJMSU5HIElUIiwgaXJxKTsKIAkJCQkJaXJxID0gMDsJLyogQ2FuJ3Qg dXNlIElSUSAqLwog
CQkJCX0gZWxzZSB7CiAJCQkJCXByaW50aygiLCBpcnE9JWQiLCBpcnEpOwpA QCAtMzcyLDkgKzM3
Miw4IEBAIHN0YXRpYyBpbnQgcGNsNzI2X2RldGFjaChzdHJ1Y3QgY29tZWRp X2RldmljZSAqZGV2
KQogLyogcHJpbnRrKCJjb21lZGklZDogcGNsNzI2OiByZW1vdmVcbiIsZGV2 LT5taW5vcik7ICov
CiAKICNpZmRlZiBBQ0w2MTI2X0lSUQotCWlmIChkZXYtPmlycSkgeworCWlm IChkZXYtPmlycSkK
IAkJZnJlZV9pcnEoZGV2LT5pcnEsIGRldik7Ci0JfQogI2VuZGlmCiAKIAlp ZiAoZGV2LT5pb2Jh
c2UpCg==
--001636d33c7cfaf8cb0476a014b5--
--
To unsubscribe from this list: send the line "unsubscribe linux-newbie" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.linux-learn.org/faqs

Re: Write and Submit Your First Kernel Patch

This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.

--1547844168-581943078-1256329969=:14365
Content-Type: TEXT/PLAIN; CHARSET=ISO-8859-15
Content-Transfer-Encoding: 8BIT
Content-ID:

On Fri, 23 Oct 2009, Kevyn-Alexandre Paré wrote:

> Hi,
>
> Just before I send my patch I got this error with:
> ./scripts/checkpatch.pl --terse --file
> 0001-Staging-comedi-driver-fix-coding-style.patch

You're using checkpatch --file on a patch. I hope you don't intend your
patch to be added to the kernel source as a file, but rather applied to
the kernel source, changing other files. (I bet "gcc 0001-Staging*.patch"
will get interesting errors, too...) The patch format adds a single
character at the beginning of each line to say whether it's a addition, a
deletion, or a context line, and the context lines are identified by a
space character. This means that a blank context line consists of just
this space character, which is therefore a trailing space. We get the same
type of complaints when we have expected diff output in our test scripts.

I'm kind of surprised that checkpatch doesn't completely blow up when it's
expecting a source file and getting a patch (and maybe tell you what
you've done). But that's the source of your errors, anyway.

-Daniel
*This .sig left intentionally blank*
--1547844168-581943078-1256329969=:14365--

Re: Write and Submit Your First Kernel Patch

--000e0cd4a5b2f773640476a021b2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

I forgot my .c file

On Fri, Oct 23, 2009 at 4:30 PM, Kevyn-Alexandre Par=E9
wrote:
> Thx junio for that analyse!
>
> So what I understand from what you have said is that the problem is
> not in format-patch since that I see white space from git show $commit
> ?!:
>
> history: I was trying to remove coding style problem in
> drivers/staging/comedi/drivers/pcl726.c
>
> ./scripts/checkpatch.pl --terse --file
> drivers/staging/comedi/drivers/pcl726.c =A0 =A0 =A0 =A0#### NO warning af=
ter
> removing problems
> ### git commit -a
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0# was done after that
> ### git format-patch -s -n master..pcl726
>
> kapare@vostro:~/linux-kernel-patch/linux-2.6$ git show $commit >
> TEST.git.show.commit =A0 =A0 =A0#### see whitespace in vim
> kapare@vostro:~/linux-kernel-patch/linux-2.6$ ./scripts/checkpatch.pl
> --terse --file TEST.git.show.commit
> TEST:19: ERROR: trailing whitespace
> TEST:27: ERROR: trailing whitespace
> TEST:35: ERROR: trailing whitespace
> TEST:45: ERROR: trailing whitespace
> TEST:55: ERROR: trailing whitespace
> TEST:60: ERROR: trailing whitespace
> TEST:67: ERROR: trailing whitespace
> TEST:69: ERROR: trailing whitespace
> TEST:80: ERROR: trailing whitespace
> TEST:106: ERROR: trailing whitespace
> TEST:113: ERROR: trailing whitespace
>
> So what am I doing wrong? Any clues? see attachment you ask
>
> thx
>
> kap
>
> On Fri, Oct 23, 2009 at 3:52 PM, Junio C Hamano wrote=
:
>> Kevyn-Alexandre Par=E9 =A0 writes:
>>
>>> Just before I send my patch I got this error with:
>>> ./scripts/checkpatch.pl --terse --file
>>> 0001-Staging-comedi-driver-fix-coding-style.patch
>>>
>>> 0001-Staging-comedi-driver-fix-coding-style.patch:27: ERROR: trailing w=
hitespace
>>> 0001-Staging-comedi-driver-fix-coding-style.patch:35: ERROR: trailing w=
hitespace
>>> 0001-Staging-comedi-driver-fix-coding-style.patch:43: ERROR: trailing w=
hitespace
>>> 0001-Staging-comedi-driver-fix-coding-style.patch:53: ERROR: trailing w=
hitespace
>>>
>>> I have done a step by step explanation of what I have done:
>>> http://kapare.blogspot.com/2009/09/write-and-submit-your-fir st-kernel.h=
tml
>>>
>>> It seem to me that the whitespace are added after I do this command:
>>> git format-patch -s -n master..mybranch
>>
>> "The whitespace are added after..." sounds to me that what you committed
>> were checkpatch compliant, and format-patch somehow broke it. =A0If that=
is
>> the case we need to fix format-patch.
>>
>> Please check if "git show $commit" output for the commit that correspond=
s
>> to the "[Staging] comedi driver: fix coding style" patch has trailing
>> whitespaces. =A0That is what you committed.
>>
>> If there already is whitespace breakage in what you committed, then we d=
o
>> not have to blame format-patch and look for bugs in it to fix.
>>
>> Otherwise, please send 0001-*.patch (output from format-patch) and outpu=
t
>> from that "git show $commit" as separate attachments, so that we can deb=
ug
>> and fix format-patch.
>>
>> Thanks.
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-newbie" =
in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at =A0http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.linux-learn.org/faqs
>>
>

--000e0cd4a5b2f773640476a021b2
Content-Type: text/x-csrc; charset=US-ASCII; name="pcl726.c"
Content-Disposition: attachment; filename="pcl726.c"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g15ede7b2

LyoKICAgIGNvbWVkaS9kcml2ZXJzL3BjbDcyNi5jCgogICAgaGFyZHdhcmUg ZHJpdmVyIGZvciBB
ZHZhbnRlY2ggY2FyZHM6CiAgICAgY2FyZDogICBQQ0wtNzI2LCBQQ0wtNzI3 LCBQQ0wtNzI4CiAg
ICAgZHJpdmVyOiBwY2w3MjYsICBwY2w3MjcsICBwY2w3MjgKICAgIGFuZCBm b3IgQURMaW5rIGNh
cmRzOgogICAgIGNhcmQ6ICAgQUNMLTYxMjYsIEFDTC02MTI4CiAgICAgZHJp dmVyOiBhY2w2MTI2
LCAgYWNsNjEyOAoKICAgIENPTUVESSAtIExpbnV4IENvbnRyb2wgYW5kIE1l YXN1cmVtZW50IERl
dmljZSBJbnRlcmZhY2UKICAgIENvcHlyaWdodCAoQykgMTk5OCBEYXZpZCBB LiBTY2hsZWVmIDxk
c0BzY2hsZWVmLm9yZz4KCiAgICBUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0 d2FyZTsgeW91IGNh
biByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQogICAgaXQgdW5kZXIg dGhlIHRlcm1zIG9m
IHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQg YnkKICAgIHRoZSBG
cmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDIgb2Yg dGhlIExpY2Vuc2Us
IG9yCiAgICAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgoK ICAgIFRoaXMgcHJv
Z3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwg YmUgdXNlZnVsLAog
ICAgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhl IGltcGxpZWQgd2Fy
cmFudHkgb2YKICAgIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBB IFBBUlRJQ1VMQVIg
UFVSUE9TRS4gIFNlZSB0aGUKICAgIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNl bnNlIGZvciBtb3Jl
IGRldGFpbHMuCgogICAgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29w eSBvZiB0aGUgR05V
IEdlbmVyYWwgUHVibGljIExpY2Vuc2UKICAgIGFsb25nIHdpdGggdGhpcyBw cm9ncmFtOyBpZiBu
b3QsIHdyaXRlIHRvIHRoZSBGcmVlIFNvZnR3YXJlCiAgICBGb3VuZGF0aW9u LCBJbmMuLCA2NzUg
TWFzcyBBdmUsIENhbWJyaWRnZSwgTUEgMDIxMzksIFVTQS4KCiovCi8qCkRy aXZlcjogcGNsNzI2
CkRlc2NyaXB0aW9uOiBBZHZhbnRlY2ggUENMLTcyNiAmIGNvbXBhdGlibGVz CkF1dGhvcjogZHMK
U3RhdHVzOiB1bnRlc3RlZApEZXZpY2VzOiBbQWR2YW50ZWNoXSBQQ0wtNzI2 IChwY2w3MjYpLCBQ
Q0wtNzI3IChwY2w3MjcpLCBQQ0wtNzI4IChwY2w3MjgpLAogIFtBRExpbmtd IEFDTC02MTI2IChh
Y2w2MTI2KSwgQUNMLTYxMjggKGFjbDYxMjgpCgpJbnRlcnJ1cHRzIGFyZSBu b3Qgc3VwcG9ydGVk
LgoKICAgIE9wdGlvbnMgZm9yIFBDTC03MjY6CiAgICAgWzBdIC0gSU8gQmFz ZQogICAgIFsyXS4u
Lls3XSAtIEQvQSBvdXRwdXQgcmFuZ2UgZm9yIGNoYW5uZWwgMS02OgoJCTA6 IDAtNVYsIDE6IDAt
MTBWLCAyOiArLy01ViwgMzogKy8tMTBWLAoJCTQ6IDQtMjBtQSwgNTogdW5r bm93biAoZXh0ZXJu
YWwgcmVmZXJlbmNlKQoKICAgIE9wdGlvbnMgZm9yIFBDTC03Mjc6CiAgICAg WzBdIC0gSU8gQmFz
ZQogICAgIFsyXS4uLlsxM10gLSBEL0Egb3V0cHV0IHJhbmdlIGZvciBjaGFu bmVsIDEtMTI6CgkJ
MDogMC01ViwgMTogMC0xMFYsIDI6ICsvLTVWLAoJCTM6IDQtMjBtQQoKICAg IE9wdGlvbnMgZm9y
IFBDTC03MjggYW5kIEFDTC02MTI4OgogICAgIFswXSAtIElPIEJhc2UKICAg ICBbMl0sIFszXSAt
IEQvQSBvdXRwdXQgcmFuZ2UgZm9yIGNoYW5uZWwgMSBhbmQgMjoKCQkwOiAw LTVWLCAxOiAwLTEw
ViwgMjogKy8tNVYsIDM6ICsvLTEwViwKCQk0OiA0LTIwbUEsIDU6IDAtMjBt QQoKICAgIE9wdGlv
bnMgZm9yIEFDTC02MTI2OgogICAgIFswXSAtIElPIEJhc2UKICAgICBbMV0g LSBJUlEgKDA9ZGlz
YWJsZSwgMywgNSwgNiwgNywgOSwgMTAsIDExLCAxMiwgMTUpIChjdXJyZW50 bHkgaWdub3JlZCkK
ICAgICBbMl0uLi5bN10gLSBEL0Egb3V0cHV0IHJhbmdlIGZvciBjaGFubmVs IDEtNjoKCQkwOiAw
LTVWLCAxOiAwLTEwViwgMjogKy8tNVYsIDM6ICsvLTEwViwKCQk0OiA0LTIw bUEKKi8KCi8qCiAg
ICBUaGFua3MgdG8gQ2lyY3VpdCBTcGVjaWFsaXN0cyBmb3IgaGF2aW5nIHBy b2dyYW1taW5nIGlu
Zm8gKCEpIG9uCiAgICB0aGVpciB3ZWIgcGFnZS4gIChodHRwOi8vd3d3LmNp ci5jb20vKQoqLwoK
I2luY2x1ZGUgIi4uL2NvbWVkaWRldi5oIgoKI2luY2x1ZGUgPGxpbnV4L2lv cG9ydC5oPgoKI3Vu
ZGVmIEFDTDYxMjZfSVJRCQkvKiBubyBpbnRlcnJ1cHQgc3VwcG9ydCAoeWV0 KSAqLwoKI2RlZmlu
ZSBQQ0w3MjZfU0laRSAxNgojZGVmaW5lIFBDTDcyN19TSVpFIDMyCiNkZWZp bmUgUENMNzI4X1NJ
WkUgOAoKI2RlZmluZSBQQ0w3MjZfREFDMF9ISSAwCiNkZWZpbmUgUENMNzI2 X0RBQzBfTE8gMQoK
I2RlZmluZSBQQ0w3MjZfRE9fSEkgMTIKI2RlZmluZSBQQ0w3MjZfRE9fTE8g MTMKI2RlZmluZSBQ
Q0w3MjZfRElfSEkgMTQKI2RlZmluZSBQQ0w3MjZfRElfTE8gMTUKCiNkZWZp bmUgUENMNzI3X0RP
X0hJIDI0CiNkZWZpbmUgUENMNzI3X0RPX0xPIDI1CiNkZWZpbmUgUENMNzI3 X0RJX0hJICAwCiNk
ZWZpbmUgUENMNzI3X0RJX0xPICAxCgpzdGF0aWMgY29uc3Qgc3RydWN0IGNv bWVkaV9scmFuZ2Ug
cmFuZ2VfNF8yMG1BID0geyAxLCB7UkFOR0VfbUEoNCwgMjApfSB9OwpzdGF0 aWMgY29uc3Qgc3Ry
dWN0IGNvbWVkaV9scmFuZ2UgcmFuZ2VfMF8yMG1BID0geyAxLCB7UkFOR0Vf bUEoMCwgMjApfSB9
OwoKc3RhdGljIGNvbnN0IHN0cnVjdCBjb21lZGlfbHJhbmdlICpjb25zdCBy YW5nZWxpc3RfNzI2
W10gPSB7CgkmcmFuZ2VfdW5pcG9sYXI1LCAmcmFuZ2VfdW5pcG9sYXIxMCwK CSZyYW5nZV9iaXBv
bGFyNSwgJnJhbmdlX2JpcG9sYXIxMCwKCSZyYW5nZV80XzIwbUEsICZyYW5n ZV91bmtub3duCn07
CgpzdGF0aWMgY29uc3Qgc3RydWN0IGNvbWVkaV9scmFuZ2UgKmNvbnN0IHJh bmdlbGlzdF83Mjdb
XSA9IHsKCSZyYW5nZV91bmlwb2xhcjUsICZyYW5nZV91bmlwb2xhcjEwLAoJ JnJhbmdlX2JpcG9s
YXI1LAoJJnJhbmdlXzRfMjBtQQp9OwoKc3RhdGljIGNvbnN0IHN0cnVjdCBj b21lZGlfbHJhbmdl
ICpjb25zdCByYW5nZWxpc3RfNzI4W10gPSB7CgkmcmFuZ2VfdW5pcG9sYXI1 LCAmcmFuZ2VfdW5p
cG9sYXIxMCwKCSZyYW5nZV9iaXBvbGFyNSwgJnJhbmdlX2JpcG9sYXIxMCwK CSZyYW5nZV80XzIw
bUEsICZyYW5nZV8wXzIwbUEKfTsKCnN0YXRpYyBpbnQgcGNsNzI2X2F0dGFj aChzdHJ1Y3QgY29t
ZWRpX2RldmljZSAqZGV2LAoJCQkgc3RydWN0IGNvbWVkaV9kZXZjb25maWcg Kml0KTsKc3RhdGlj
IGludCBwY2w3MjZfZGV0YWNoKHN0cnVjdCBjb21lZGlfZGV2aWNlICpkZXYp OwoKc3RydWN0IHBj
bDcyNl9ib2FyZCB7CgoJY29uc3QgY2hhciAqbmFtZTsJLyogIGRyaXZlciBu YW1lICovCglpbnQg
bl9hb2NoYW47CQkvKiAgbnVtIG9mIEQvQSBjaGFucyAqLwoJaW50IG51bV9v Zl9yYW5nZXM7CS8q
ICBudW0gb2YgcmFuZ2VzICovCgl1bnNpZ25lZCBpbnQgSVJRYml0czsJLyog IGFsbG93ZWQgaW50
ZXJydXB0cyAqLwoJdW5zaWduZWQgaW50IGlvX3JhbmdlOwkvKiAgbGVuIG9m IElPIHNwYWNlICov
CgljaGFyIGhhdmVfZGlvOwkJLyogIDE9Y2FyZCBoYXZlIERJL0RPIHBvcnRz ICovCglpbnQgZGlf
aGk7CQkvKiAgcG9ydHMgZm9yIERJL0RPIG9wZXJhdGlvbnMgKi8KCWludCBk aV9sbzsKCWludCBk
b19oaTsKCWludCBkb19sbzsKCWNvbnN0IHN0cnVjdCBjb21lZGlfbHJhbmdl ICpjb25zdCAqcmFu
Z2VfdHlwZV9saXN0OwoJLyogIGxpc3Qgb2Ygc3VwcG9ydGVkIHJhbmdlcyAq Lwp9OwoKc3RhdGlj
IGNvbnN0IHN0cnVjdCBwY2w3MjZfYm9hcmQgYm9hcmR0eXBlc1tdID0gewoJ eyJwY2w3MjYiLCA2
LCA2LCAweDAwMDAsIFBDTDcyNl9TSVpFLCAxLAoJIFBDTDcyNl9ESV9ISSwg UENMNzI2X0RJX0xP
LCBQQ0w3MjZfRE9fSEksIFBDTDcyNl9ET19MTywKCSAmcmFuZ2VsaXN0Xzcy NlswXSx9LAoJeyJw
Y2w3MjciLCAxMiwgNCwgMHgwMDAwLCBQQ0w3MjdfU0laRSwgMSwKCSBQQ0w3 MjdfRElfSEksIFBD
TDcyN19ESV9MTywgUENMNzI3X0RPX0hJLCBQQ0w3MjdfRE9fTE8sCgkgJnJh bmdlbGlzdF83Mjdb
MF0sfSwKCXsicGNsNzI4IiwgMiwgNiwgMHgwMDAwLCBQQ0w3MjhfU0laRSwg MCwKCSAwLCAwLCAw
LCAwLAoJICZyYW5nZWxpc3RfNzI4WzBdLH0sCgl7ImFjbDYxMjYiLCA2LCA1 LCAweDk2ZTgsIFBD
TDcyNl9TSVpFLCAxLAoJIFBDTDcyNl9ESV9ISSwgUENMNzI2X0RJX0xPLCBQ Q0w3MjZfRE9fSEks
IFBDTDcyNl9ET19MTywKCSAmcmFuZ2VsaXN0XzcyNlswXSx9LAoJeyJhY2w2 MTI4IiwgMiwgNiwg
MHgwMDAwLCBQQ0w3MjhfU0laRSwgMCwKCSAwLCAwLCAwLCAwLAoJICZyYW5n ZWxpc3RfNzI4WzBd
LH0sCn07CgojZGVmaW5lIG5fYm9hcmR0eXBlcyAoc2l6ZW9mKGJvYXJkdHlw ZXMpL3NpemVvZihz
dHJ1Y3QgcGNsNzI2X2JvYXJkKSkKI2RlZmluZSB0aGlzX2JvYXJkICgoY29u c3Qgc3RydWN0IHBj
bDcyNl9ib2FyZCAqKWRldi0+Ym9hcmRfcHRyKQoKc3RhdGljIHN0cnVjdCBj b21lZGlfZHJpdmVy
IGRyaXZlcl9wY2w3MjYgPSB7CgkuZHJpdmVyX25hbWUgPSAicGNsNzI2IiwK CS5tb2R1bGUgPSBU
SElTX01PRFVMRSwKCS5hdHRhY2ggPSBwY2w3MjZfYXR0YWNoLAoJLmRldGFj aCA9IHBjbDcyNl9k
ZXRhY2gsCgkuYm9hcmRfbmFtZSA9ICZib2FyZHR5cGVzWzBdLm5hbWUsCgku bnVtX25hbWVzID0g
bl9ib2FyZHR5cGVzLAoJLm9mZnNldCA9IHNpemVvZihzdHJ1Y3QgcGNsNzI2 X2JvYXJkKSwKfTsK
CkNPTUVESV9JTklUQ0xFQU5VUChkcml2ZXJfcGNsNzI2KTsKCnN0cnVjdCBw Y2w3MjZfcHJpdmF0
ZSB7CgoJaW50IGJpcG9sYXJbMTJdOwoJY29uc3Qgc3RydWN0IGNvbWVkaV9s cmFuZ2UgKnJhbmdl
bGlzdFsxMl07Cgl1bnNpZ25lZCBpbnQgYW9fcmVhZGJhY2tbMTJdOwp9OwoK I2RlZmluZSBkZXZw
cml2ICgoc3RydWN0IHBjbDcyNl9wcml2YXRlICopZGV2LT5wcml2YXRlKQoK c3RhdGljIGludCBw
Y2w3MjZfYW9faW5zbihzdHJ1Y3QgY29tZWRpX2RldmljZSAqZGV2LCBzdHJ1 Y3QgY29tZWRpX3N1
YmRldmljZSAqcywKCQkJICBzdHJ1Y3QgY29tZWRpX2luc24gKmluc24sIHVu c2lnbmVkIGludCAq
ZGF0YSkKewoJaW50IGhpLCBsbzsKCWludCBuOwoJaW50IGNoYW4gPSBDUl9D SEFOKGluc24tPmNo
YW5zcGVjKTsKCglmb3IgKG4gPSAwOyBuIDwgaW5zbi0+bjsgbisrKSB7CgkJ bG8gPSBkYXRhW25d
ICYgMHhmZjsKCQloaSA9IChkYXRhW25dID4+IDgpICYgMHhmOwoJCWlmIChk ZXZwcml2LT5iaXBv
bGFyW2NoYW5dKQoJCQloaSBePSAweDg7CgkJLyoKCQkgKiB0aGUgcHJvZ3Jh bW1pbmcgaW5mbyBk
aWQgbm90IHNheSB3aGljaCBvcmRlcgoJCSAqIHRvIHdyaXRlIGJ5dGVzLiAg c3dpdGNoIHRoZSBv
cmRlciBvZiB0aGUgbmV4dAoJCSAqIHR3byBsaW5lcyBpZiB5b3UgZ2V0IGds aXRjaGVzLgoJCSAq
LwoJCW91dGIoaGksIGRldi0+aW9iYXNlICsgUENMNzI2X0RBQzBfSEkgKyAy ICogY2hhbik7CgkJ
b3V0YihsbywgZGV2LT5pb2Jhc2UgKyBQQ0w3MjZfREFDMF9MTyArIDIgKiBj aGFuKTsKCQlkZXZw
cml2LT5hb19yZWFkYmFja1tjaGFuXSA9IGRhdGFbbl07Cgl9CgoJcmV0dXJu IG47Cn0KCnN0YXRp
YyBpbnQgcGNsNzI2X2FvX2luc25fcmVhZChzdHJ1Y3QgY29tZWRpX2Rldmlj ZSAqZGV2LAoJCQkg
ICAgICAgc3RydWN0IGNvbWVkaV9zdWJkZXZpY2UgKnMsCgkJCSAgICAgICBz dHJ1Y3QgY29tZWRp
X2luc24gKmluc24sIHVuc2lnbmVkIGludCAqZGF0YSkKewoJaW50IGNoYW4g PSBDUl9DSEFOKGlu
c24tPmNoYW5zcGVjKTsKCWludCBuOwoKCWZvciAobiA9IDA7IG4gPCBpbnNu LT5uOyBuKyspCgkJ
ZGF0YVtuXSA9IGRldnByaXYtPmFvX3JlYWRiYWNrW2NoYW5dOwoJcmV0dXJu IG47Cn0KCnN0YXRp
YyBpbnQgcGNsNzI2X2RpX2luc25fYml0cyhzdHJ1Y3QgY29tZWRpX2Rldmlj ZSAqZGV2LAoJCQkg
ICAgICAgc3RydWN0IGNvbWVkaV9zdWJkZXZpY2UgKnMsCgkJCSAgICAgICBz dHJ1Y3QgY29tZWRp
X2luc24gKmluc24sIHVuc2lnbmVkIGludCAqZGF0YSkKewoJaWYgKGluc24t Pm4gIT0gMikKCQly
ZXR1cm4gLUVJTlZBTDsKCglkYXRhWzFdID0gaW5iKGRldi0+aW9iYXNlICsg dGhpc19ib2FyZC0+
ZGlfbG8pIHwKCSAgICAoaW5iKGRldi0+aW9iYXNlICsgdGhpc19ib2FyZC0+ ZGlfaGkpIDw8IDgp
OwoKCXJldHVybiAyOwp9CgpzdGF0aWMgaW50IHBjbDcyNl9kb19pbnNuX2Jp dHMoc3RydWN0IGNv
bWVkaV9kZXZpY2UgKmRldiwKCQkJICAgICAgIHN0cnVjdCBjb21lZGlfc3Vi ZGV2aWNlICpzLAoJ
CQkgICAgICAgc3RydWN0IGNvbWVkaV9pbnNuICppbnNuLCB1bnNpZ25lZCBp bnQgKmRhdGEpCnsK
CWlmIChpbnNuLT5uICE9IDIpCgkJcmV0dXJuIC1FSU5WQUw7CgoJaWYgKGRh dGFbMF0pIHsKCQlz
LT5zdGF0ZSAmPSB+ZGF0YVswXTsKCQlzLT5zdGF0ZSB8PSBkYXRhWzBdICYg ZGF0YVsxXTsKCX0K
CWlmIChkYXRhWzFdICYgMHgwMGZmKQoJCW91dGIocy0+c3RhdGUgJiAweGZm LCBkZXYtPmlvYmFz
ZSArIHRoaXNfYm9hcmQtPmRvX2xvKTsKCWlmIChkYXRhWzFdICYgMHhmZjAw KQoJCW91dGIoKHMt
PnN0YXRlID4+IDgpLCBkZXYtPmlvYmFzZSArIHRoaXNfYm9hcmQtPmRvX2hp KTsKCglkYXRhWzFd
ID0gcy0+c3RhdGU7CgoJcmV0dXJuIDI7Cn0KCnN0YXRpYyBpbnQgcGNsNzI2 X2F0dGFjaChzdHJ1
Y3QgY29tZWRpX2RldmljZSAqZGV2LCBzdHJ1Y3QgY29tZWRpX2RldmNvbmZp ZyAqaXQpCnsKCXN0
cnVjdCBjb21lZGlfc3ViZGV2aWNlICpzOwoJdW5zaWduZWQgbG9uZyBpb2Jh c2U7Cgl1bnNpZ25l
ZCBpbnQgaW9yYW5nZTsKCWludCByZXQsIGk7CiNpZmRlZiBBQ0w2MTI2X0lS UQoJdW5zaWduZWQg
aW50IGlycTsKI2VuZGlmCgoJaW9iYXNlID0gaXQtPm9wdGlvbnNbMF07Cglp b3JhbmdlID0gdGhp
c19ib2FyZC0+aW9fcmFuZ2U7CglwcmludGsoS0VSTl9XQVJOSU5HLCAiY29t ZWRpJWQ6IHBjbDcy
NjogYm9hcmQ9JXMsIDB4JTAzbHggIiwgZGV2LT5taW5vciwKCSAgICAgICB0 aGlzX2JvYXJkLT5u
YW1lLCBpb2Jhc2UpOwoJaWYgKCFyZXF1ZXN0X3JlZ2lvbihpb2Jhc2UsIGlv cmFuZ2UsICJwY2w3
MjYiKSkgewoJCXByaW50ayhLRVJOX1dBUk5JTkcsICJJL08gcG9ydCBjb25m bGljdFxuIik7CgkJ
cmV0dXJuIC1FSU87Cgl9CgoJZGV2LT5pb2Jhc2UgPSBpb2Jhc2U7CgoJZGV2 LT5ib2FyZF9uYW1l
ID0gdGhpc19ib2FyZC0+bmFtZTsKCglyZXQgPSBhbGxvY19wcml2YXRlKGRl diwgc2l6ZW9mKHN0
cnVjdCBwY2w3MjZfcHJpdmF0ZSkpOwoJaWYgKHJldCA8IDApCgkJcmV0dXJu IC1FTk9NRU07CgoJ
Zm9yIChpID0gMDsgaSA8IDEyOyBpKyspIHsKCQlkZXZwcml2LT5iaXBvbGFy W2ldID0gMDsKCQlk
ZXZwcml2LT5yYW5nZWxpc3RbaV0gPSAmcmFuZ2VfdW5rbm93bjsKCX0KCiNp ZmRlZiBBQ0w2MTI2
X0lSUQoJaXJxID0gMDsKCWlmIChib2FyZHR5cGVzW2JvYXJkXS5JUlFiaXRz ICE9IDApIHsJLyog
Ym9hcmQgc3VwcG9ydCBJUlEgKi8KCQlpcnEgPSBpdC0+b3B0aW9uc1sxXTsK CQlkZXZwcml2LT5m
aXJzdF9jaGFuID0gMjsKCQlpZiAoaXJxKSB7CS8qIHdlIHdhbnQgdG8gdXNl IElSUSAqLwoJCQlp
ZiAoKCgxIDw8IGlycSkgJiBib2FyZHR5cGVzW2JvYXJkXS5JUlFiaXRzKSA9 PSAwKSB7CgkJCQlw
cmludGsoS0VSTl9XQVJOSU5HLAoJCQkJCSIsIElSUSAlZCBpcyBvdXQgb2Yg YWxsb3dlZCByYW5n
ZSwiCgkJCQkJIiBESVNBQkxJTkcgSVQiLCBpcnEpOwoJCQkJaXJxID0gMDsJ LyogQmFkIElSUSAq
LwoJCQl9IGVsc2UgewoJCQkJaWYgKHJlcXVlc3RfaXJxKGlycSwgaW50ZXJy dXB0X3BjbDgxOCwg
MCwKCQkJCQkJInBjbDcyNiIsIGRldikpIHsKCQkJCQlwcmludGsoS0VSTl9X QVJOSU5HLAoJCQkJ
CQkiLCB1bmFibGUgdG8gYWxsb2NhdGUgSVJRICVkLCIKCQkJCQkJIiBESVNB QkxJTkcgSVQiLCBp
cnEpOwoJCQkJCWlycSA9IDA7CS8qIENhbid0IHVzZSBJUlEgKi8KCQkJCX0g ZWxzZSB7CgkJCQkJ
cHJpbnRrKCIsIGlycT0lZCIsIGlycSk7CgkJCQl9CgkJCX0KCQl9Cgl9CgoJ ZGV2LT5pcnEgPSBp
cnE7CiNlbmRpZgoKCXByaW50aygiXG4iKTsKCglyZXQgPSBhbGxvY19zdWJk ZXZpY2VzKGRldiwg
Myk7CglpZiAocmV0IDwgMCkKCQlyZXR1cm4gcmV0OwoKCXMgPSBkZXYtPnN1 YmRldmljZXMgKyAw
OwoJLyogYW8gKi8KCXMtPnR5cGUgPSBDT01FRElfU1VCRF9BTzsKCXMtPnN1 YmRldl9mbGFncyA9
IFNERl9XUklUQUJMRSB8IFNERl9HUk9VTkQ7CglzLT5uX2NoYW4gPSB0aGlz X2JvYXJkLT5uX2Fv
Y2hhbjsKCXMtPm1heGRhdGEgPSAweGZmZjsKCXMtPmxlbl9jaGFubGlzdCA9 IDE7CglzLT5pbnNu
X3dyaXRlID0gcGNsNzI2X2FvX2luc247CglzLT5pbnNuX3JlYWQgPSBwY2w3 MjZfYW9faW5zbl9y
ZWFkOwoJcy0+cmFuZ2VfdGFibGVfbGlzdCA9IGRldnByaXYtPnJhbmdlbGlz dDsKCWZvciAoaSA9
IDA7IGkgPCB0aGlzX2JvYXJkLT5uX2FvY2hhbjsgaSsrKSB7CgkJaW50IGo7 CgoJCWogPSBpdC0+
b3B0aW9uc1syICsgMV07CgkJaWYgKChqIDwgMCkgfHwgKGogPj0gdGhpc19i b2FyZC0+bnVtX29m
X3JhbmdlcykpIHsKCQkJcHJpbnRrCgkJCSAgICAoIkludmFsaWQgcmFuZ2Ug Zm9yIGNoYW5uZWwg
JWQhIE11c3QgYmUgMDw9JWQ8JWRcbiIsCgkJCSAgICAgaSwgaiwgdGhpc19i b2FyZC0+bnVtX29m
X3JhbmdlcyAtIDEpOwoJCQlqID0gMDsKCQl9CgkJZGV2cHJpdi0+cmFuZ2Vs aXN0W2ldID0gdGhp
c19ib2FyZC0+cmFuZ2VfdHlwZV9saXN0W2pdOwoJCWlmIChkZXZwcml2LT5y YW5nZWxpc3RbaV0t
PnJhbmdlWzBdLm1pbiA9PQoJCSAgICAtZGV2cHJpdi0+cmFuZ2VsaXN0W2ld LT5yYW5nZVswXS5t
YXgpCgkJCWRldnByaXYtPmJpcG9sYXJbaV0gPSAxOwkvKiBiaXBvbGFyIHJh bmdlICovCgl9CgoJ
cyA9IGRldi0+c3ViZGV2aWNlcyArIDE7CgkvKiBkaSAqLwoJaWYgKCF0aGlz X2JvYXJkLT5oYXZl
X2RpbykgewoJCXMtPnR5cGUgPSBDT01FRElfU1VCRF9VTlVTRUQ7Cgl9IGVs c2UgewoJCXMtPnR5
cGUgPSBDT01FRElfU1VCRF9ESTsKCQlzLT5zdWJkZXZfZmxhZ3MgPSBTREZf UkVBREFCTEUgfCBT
REZfR1JPVU5EOwoJCXMtPm5fY2hhbiA9IDE2OwoJCXMtPm1heGRhdGEgPSAx OwoJCXMtPmxlbl9j
aGFubGlzdCA9IDE7CgkJcy0+aW5zbl9iaXRzID0gcGNsNzI2X2RpX2luc25f Yml0czsKCQlzLT5y
YW5nZV90YWJsZSA9ICZyYW5nZV9kaWdpdGFsOwoJfQoKCXMgPSBkZXYtPnN1 YmRldmljZXMgKyAy
OwoJLyogZG8gKi8KCWlmICghdGhpc19ib2FyZC0+aGF2ZV9kaW8pIHsKCQlz LT50eXBlID0gQ09N
RURJX1NVQkRfVU5VU0VEOwoJfSBlbHNlIHsKCQlzLT50eXBlID0gQ09NRURJ X1NVQkRfRE87CgkJ
cy0+c3ViZGV2X2ZsYWdzID0gU0RGX1dSSVRBQkxFIHwgU0RGX0dST1VORDsK CQlzLT5uX2NoYW4g
PSAxNjsKCQlzLT5tYXhkYXRhID0gMTsKCQlzLT5sZW5fY2hhbmxpc3QgPSAx OwoJCXMtPmluc25f
Yml0cyA9IHBjbDcyNl9kb19pbnNuX2JpdHM7CgkJcy0+cmFuZ2VfdGFibGUg PSAmcmFuZ2VfZGln
aXRhbDsKCX0KCglyZXR1cm4gMDsKfQoKc3RhdGljIGludCBwY2w3MjZfZGV0 YWNoKHN0cnVjdCBj
b21lZGlfZGV2aWNlICpkZXYpCnsKLyogcHJpbnRrKCJjb21lZGklZDogcGNs NzI2OiByZW1vdmVc
biIsZGV2LT5taW5vcik7ICovCgojaWZkZWYgQUNMNjEyNl9JUlEKCWlmIChk ZXYtPmlycSkKCQlm
cmVlX2lycShkZXYtPmlycSwgZGV2KTsKI2VuZGlmCgoJaWYgKGRldi0+aW9i YXNlKQoJCXJlbGVh
c2VfcmVnaW9uKGRldi0+aW9iYXNlLCB0aGlzX2JvYXJkLT5pb19yYW5nZSk7 CgoJcmV0dXJuIDA7
Cn0K
--000e0cd4a5b2f773640476a021b2--

Re: Write and Submit Your First Kernel Patch

Daniel Barkalow writes:

> On Fri, 23 Oct 2009, Kevyn-Alexandre Paré wrote:
>
>> Just before I send my patch I got this error with:
>> ./scripts/checkpatch.pl --terse --file
>> 0001-Staging-comedi-driver-fix-coding-style.patch
>
> You're using checkpatch --file on a patch. I hope you don't intend yo=
ur=20
> patch to be added to the kernel source as a file, but rather applied =
to=20
> the kernel source, changing other files. (I bet "gcc 0001-Staging*.pa=
tch"=20
> will get interesting errors, too...) The patch format adds a single=20
> character at the beginning of each line to say whether it's a additio=
n, a=20
> deletion, or a context line, and the context lines are identified by =
a=20
> space character. This means that a blank context line consists of jus=
t=20
> this space character, which is therefore a trailing space. We get the=
same=20
> type of complaints when we have expected diff output in our test scri=
pts.
>
> I'm kind of surprised that checkpatch doesn't completely blow up when=
it's=20
> expecting a source file and getting a patch (and maybe tell you what=20
> you've done). But that's the source of your errors, anyway.

Ah, your analysis is correct. This is a usage error of checkpatch scri=
pt
and there is nothing for us to worry about.

Thanks; I also failed to spot --file option when I responded.
--
To unsubscribe from this list: send the line "unsubscribe linux-newbie"=
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.linux-learn.org/faqs

Re: Write and Submit Your First Kernel Patch

My mistake but I learn a lot from you guys!

I should simply have done:
/scripts/checkpatch.pl --terse --patch
0001-Staging-comedi-driver-fix-coding-style.patch

or

/scripts/checkpatch.pl --terse --patch
0001-Staging-comedi-driver-fix-coding-style.patch
# Since --patch is the default!

No warning to the output, I will change my blog

thx again

kap

On Fri, Oct 23, 2009 at 4:58 PM, Junio C Hamano wro=
te:
> Daniel Barkalow writes:
>
>> On Fri, 23 Oct 2009, Kevyn-Alexandre Par=E9 wrote:
>>
>>> Just before I send my patch I got this error with:
>>> ./scripts/checkpatch.pl --terse --file
>>> 0001-Staging-comedi-driver-fix-coding-style.patch
>>
>> You're using checkpatch --file on a patch. I hope you don't intend y=
our
>> patch to be added to the kernel source as a file, but rather applied=
to
>> the kernel source, changing other files. (I bet "gcc 0001-Staging*.p=
atch"
>> will get interesting errors, too...) The patch format adds a single
>> character at the beginning of each line to say whether it's a additi=
on, a
>> deletion, or a context line, and the context lines are identified by=
a
>> space character. This means that a blank context line consists of ju=
st
>> this space character, which is therefore a trailing space. We get th=
e same
>> type of complaints when we have expected diff output in our test scr=
ipts.
>>
>> I'm kind of surprised that checkpatch doesn't completely blow up whe=
n it's
>> expecting a source file and getting a patch (and maybe tell you what
>> you've done). But that's the source of your errors, anyway.
>
> Ah, your analysis is correct. =A0This is a usage error of checkpatch =
script
> and there is nothing for us to worry about.
>
> Thanks; I also failed to spot --file option when I responded.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-newbie"=
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.linux-learn.org/faqs