[PATCH 1/4] imsm: FIX: add raid5 to raid0 case to analyse_change()
am 09.02.2011 14:47:37 von adam.kwolek
Transition raid0 to raid5 is not possible
due to wrong condition in imsm_analyze_change().
Current condition blocks migration possibility instead allow for it.
Signed-off-by: Adam Kwolek
---
super-intel.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/super-intel.c b/super-intel.c
index 6a21b26..2875ade 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -6934,7 +6934,7 @@ enum imsm_reshape_type imsm_analyze_change(struct supertype *st,
}
break;
case 5:
- if (geo->level != 0)
+ if (geo->level == 0)
change = CH_LEVEL_MIGRATION;
break;
case 10:
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4/4] imsm: Add information about failed disk to "-E" option
am 09.02.2011 14:48:03 von adam.kwolek
During metadata printout in '-E' option failed disk map field information is missing.
Add this information to mdadm '-E' option output.
Signed-off-by: Adam Kwolek
---
super-intel.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/super-intel.c b/super-intel.c
index 876cc4c..4a9c230 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -897,6 +897,12 @@ static void print_imsm_dev(struct imsm_dev *dev, char *uuid, int disk_idx)
printf("]");
}
printf("\n");
+ printf(" Failed disk : ");
+ if (map->failed_disk_num == 0xff)
+ printf("none");
+ else
+ printf("%i", map->failed_disk_num);
+ printf("\n");
slot = get_imsm_disk_slot(map, disk_idx);
if (slot >= 0) {
ord = get_imsm_ord_tbl_ent(dev, slot, -1);
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] imsm: FIX: add raid5 to raid0 case toanalyse_change()
am 13.02.2011 23:26:42 von NeilBrown
On Wed, 09 Feb 2011 14:47:37 +0100 Adam Kwolek wrote:
> Transition raid0 to raid5 is not possible
> due to wrong condition in imsm_analyze_change().
> Current condition blocks migration possibility instead allow for it.
>
> Signed-off-by: Adam Kwolek
Thanks. All 4 in this series applied.
NeilBrown
> ---
>
> super-intel.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index 6a21b26..2875ade 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -6934,7 +6934,7 @@ enum imsm_reshape_type imsm_analyze_change(struct supertype *st,
> }
> break;
> case 5:
> - if (geo->level != 0)
> + if (geo->level == 0)
> change = CH_LEVEL_MIGRATION;
> break;
> case 10:
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html