Re: [PULL REQUEST] md and related patches for 2.6.38

On Wed, Feb 23, 2011 at 9:53 PM, NeilBrown wrote:
>
> =A0The most noteworthy is :
> =A0 =A0 =A0 Fix over-zealous flush_disk when changing device size.
>
> =A0which I include below in full.

Gah.

Why did you do that butt-ugly "__invalidate_device2()"?

There are something like three users of that existing
__invalidate_device() function, it would have made for a smaller and
cleaner patch to just fix them all, rather than change the calling
convention, create that ugly "2" function, and add the wrapper
function.

It's _doubly_ crazy, because that's exactly what you did to
"invalidate_inodes()", so it has this crazy mix of "change one
function" and "try to maintain another function unchanged".

Why?

Linus