[PATCH] Enable error message in case of lack of spares for grow

[PATCH] Enable error message in case of lack of spares for grow

am 02.03.2011 17:33:01 von krzysztof.wojcik

When we cannot find spare devices for grow operation we should
print error message.
This patch changes debug error message to 'stderr' print.

Signed-off-by: Krzysztof Wojcik
---
super-intel.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/super-intel.c b/super-intel.c
index 5b09bc5..fde29b8 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -7112,7 +7112,8 @@ static int imsm_create_metadata_update_for_reshape(

if (spares == NULL
|| delta_disks > spares->array.spare_disks) {
- dprintf("imsm: ERROR: Cannot get spare devices.\n");
+ fprintf(stderr, Name ": imsm: ERROR: Cannot get spare devices "
+ "for %s.\n", geo->dev_name);
goto abort;
}


--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Enable error message in case of lack of spares for grow

am 07.03.2011 23:53:21 von NeilBrown

On Wed, 02 Mar 2011 17:33:01 +0100 Krzysztof Wojcik
wrote:

> When we cannot find spare devices for grow operation we should
> print error message.
> This patch changes debug error message to 'stderr' print.
>
> Signed-off-by: Krzysztof Wojcik
> ---
> super-intel.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index 5b09bc5..fde29b8 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -7112,7 +7112,8 @@ static int imsm_create_metadata_update_for_reshape(
>
> if (spares == NULL
> || delta_disks > spares->array.spare_disks) {
> - dprintf("imsm: ERROR: Cannot get spare devices.\n");
> + fprintf(stderr, Name ": imsm: ERROR: Cannot get spare devices "
> + "for %s.\n", geo->dev_name);
> goto abort;
> }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

Applied,
thanks.

NeilBrown

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html