[PATCH resend 0/6] use little-endian bitops properly

[PATCH resend 0/6] use little-endian bitops properly

am 26.06.2011 07:57:50 von Akinobu Mita

All patches in this patch set were sent before. Individual patches
improve little-endian bitops usage in several places.

Akinobu Mita (6):
ext4: use proper little-endian bitops
dm: use use proper little-endian bitops
md: use proper little-endian bitops
reiserfs: use proper little-endian bitops
reiserfs: use hweight_long()
ocfs2: avoid unaligned access to dqc_bitmap

drivers/md/bitmap.c | 4 +-
drivers/md/dm-log.c | 9 +++----
fs/ext4/ext4.h | 7 +++--
fs/ext4/ialloc.c | 4 +-
fs/ocfs2/ocfs2.h | 47 +++++++++++++++++++++++++++++++++++++++++++
fs/ocfs2/quota_local.c | 10 ++++----
fs/reiserfs/bitmap.c | 8 +-----
fs/reiserfs/resize.c | 6 ++--
include/linux/reiserfs_fs.h | 2 +
9 files changed, 71 insertions(+), 26 deletions(-)

Cc: "Theodore Ts'o"
Cc: Andreas Dilger
Cc: linux-ext4@vger.kernel.org
Cc: Alasdair Kergon
Cc: dm-devel@redhat.com
Cc: NeilBrown
Cc: linux-raid@vger.kernel.org
Cc: reiserfs-devel@vger.kernel.org
Cc: Joel Becker
Cc: Mark Fasheh
Cc: ocfs2-devel@oss.oracle.com

--
1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH resend 3/6] md: use proper little-endian bitops

am 26.06.2011 07:57:53 von Akinobu Mita

Using __test_and_{set,clear}_bit_le() with ignoring its return value
can be replaced with __{set,clear}_bit_le().

Signed-off-by: Akinobu Mita
Cc: NeilBrown
Cc: linux-raid@vger.kernel.org
---
drivers/md/bitmap.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
index 574b09a..870a7fc 100644
--- a/drivers/md/bitmap.c
+++ b/drivers/md/bitmap.c
@@ -932,7 +932,7 @@ static void bitmap_file_set_bit(struct bitmap *bitmap, sector_t block)
if (bitmap->flags & BITMAP_HOSTENDIAN)
set_bit(bit, kaddr);
else
- __test_and_set_bit_le(bit, kaddr);
+ __set_bit_le(bit, kaddr);
kunmap_atomic(kaddr, KM_USER0);
PRINTK("set file bit %lu page %lu\n", bit, page->index);
}
@@ -1304,7 +1304,7 @@ void bitmap_daemon_work(mddev_t *mddev)
clear_bit(file_page_offset(bitmap, j),
paddr);
else
- __test_and_clear_bit_le(file_page_offset(bitmap, j),
+ __clear_bit_le(file_page_offset(bitmap, j),
paddr);
kunmap_atomic(paddr, KM_USER0);
} else
--
1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH resend 3/6] md: use proper little-endian bitops

am 28.06.2011 08:43:28 von NeilBrown

On Sun, 26 Jun 2011 14:57:53 +0900 Akinobu Mita
wrote:

> Using __test_and_{set,clear}_bit_le() with ignoring its return value
> can be replaced with __{set,clear}_bit_le().
>
> Signed-off-by: Akinobu Mita
> Cc: NeilBrown
> Cc: linux-raid@vger.kernel.org
> ---
> drivers/md/bitmap.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
> index 574b09a..870a7fc 100644
> --- a/drivers/md/bitmap.c
> +++ b/drivers/md/bitmap.c
> @@ -932,7 +932,7 @@ static void bitmap_file_set_bit(struct bitmap *bitmap, sector_t block)
> if (bitmap->flags & BITMAP_HOSTENDIAN)
> set_bit(bit, kaddr);
> else
> - __test_and_set_bit_le(bit, kaddr);
> + __set_bit_le(bit, kaddr);
> kunmap_atomic(kaddr, KM_USER0);
> PRINTK("set file bit %lu page %lu\n", bit, page->index);
> }
> @@ -1304,7 +1304,7 @@ void bitmap_daemon_work(mddev_t *mddev)
> clear_bit(file_page_offset(bitmap, j),
> paddr);
> else
> - __test_and_clear_bit_le(file_page_offset(bitmap, j),
> + __clear_bit_le(file_page_offset(bitmap, j),
> paddr);
> kunmap_atomic(paddr, KM_USER0);
> } else


Thanks. I've applied this one to my 'md' tree.

NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html