linux-next: build warnings after merge of the moduleh tree

linux-next: build warnings after merge of the moduleh tree

am 29.07.2011 07:25:48 von Stephen Rothwell

Hi Paul,

After merging the moduleh tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/md/persistent-data/dm-block-manager.c:103:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:103:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:103:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-block-manager.c:109:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:109:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:109:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-block-manager.c:670:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:670:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:670:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-block-manager.c:692:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:692:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:692:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-block-manager.c:698:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:698:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:698:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-block-manager.c:816:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:816:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:816:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-block-manager.c:824:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:824:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:824:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-block-manager.c:881:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:881:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:881:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-block-manager.c:946:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:946:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:946:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-space-map-disk.c:634:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-space-map-disk.c:634:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-space-map-disk.c:634:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-space-map-disk.c:662:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-space-map-disk.c:662:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-space-map-disk.c:662:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree.c:146:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree.c:146:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree.c:146:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree.c:293:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree.c:293:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree.c:293:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree.c:301:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree.c:301:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree.c:301:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree.c:378:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree.c:378:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree.c:378:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree.c:756:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree.c:756:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree.c:756:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree.c:765:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree.c:765:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree.c:765:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree.c:801:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree.c:801:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree.c:801:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree.c:857:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree.c:857:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree.c:857:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree-remove.c:569:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree-remove.c:569:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree-remove.c:569:1: warning: parameter names (without types) in function declaration

I have added the following patch for today:

From: Stephen Rothwell
Date: Fri, 29 Jul 2011 15:16:04 +1000
Subject: [PATCH] include export.h to use EXPORT_SYMBOL

Signed-off-by: Stephen Rothwell
---
drivers/md/persistent-data/dm-block-manager.c | 1 +
drivers/md/persistent-data/dm-btree-remove.c | 2 ++
drivers/md/persistent-data/dm-btree.c | 1 +
drivers/md/persistent-data/dm-space-map-disk.c | 1 +
4 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/md/persistent-data/dm-block-manager.c b/drivers/md/persistent-data/dm-block-manager.c
index 4ec480c..7b8e84c 100644
--- a/drivers/md/persistent-data/dm-block-manager.c
+++ b/drivers/md/persistent-data/dm-block-manager.c
@@ -9,6 +9,7 @@
#include
#include
#include
+#include

#define DM_MSG_PREFIX "block manager"

diff --git a/drivers/md/persistent-data/dm-btree-remove.c b/drivers/md/persistent-data/dm-btree-remove.c
index 72c9705..e7071f6 100644
--- a/drivers/md/persistent-data/dm-btree-remove.c
+++ b/drivers/md/persistent-data/dm-btree-remove.c
@@ -8,6 +8,8 @@
#include "dm-btree-internal.h"
#include "dm-transaction-manager.h"

+#include
+
/*
* Removing an entry from a btree
* ==============================
diff --git a/drivers/md/persistent-data/dm-btree.c b/drivers/md/persistent-data/dm-btree.c
index 55b8bf3..7cad5e8 100644
--- a/drivers/md/persistent-data/dm-btree.c
+++ b/drivers/md/persistent-data/dm-btree.c
@@ -9,6 +9,7 @@
#include "dm-transaction-manager.h"

#include
+#include

#define DM_MSG_PREFIX "btree"

diff --git a/drivers/md/persistent-data/dm-space-map-disk.c b/drivers/md/persistent-data/dm-space-map-disk.c
index de31096..26e6e19 100644
--- a/drivers/md/persistent-data/dm-space-map-disk.c
+++ b/drivers/md/persistent-data/dm-space-map-disk.c
@@ -13,6 +13,7 @@
#include
#include
#include
+#include

#define DM_MSG_PREFIX "space map disk"

--
1.7.5.4

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build warnings after merge of the moduleh tree

am 31.07.2011 10:24:05 von Paul Gortmaker

[linux-next: build warnings after merge of the moduleh tree] On 29/07/2011 (Fri 15:25) Stephen Rothwell wrote:

> Hi Paul,
>
> After merging the moduleh tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
>
> drivers/md/persistent-data/dm-block-manager.c:103:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
[...]
> drivers/md/persistent-data/dm-space-map-disk.c:634:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
[...]
> drivers/md/persistent-data/dm-btree.c:146:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
[...]
> drivers/md/persistent-data/dm-btree-remove.c:569:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
>
> I have added the following patch for today:
>
> From: Stephen Rothwell
> Date: Fri, 29 Jul 2011 15:16:04 +1000
> Subject: [PATCH] include export.h to use EXPORT_SYMBOL
>
> Signed-off-by: Stephen Rothwell
> ---
> drivers/md/persistent-data/dm-block-manager.c | 1 +
> drivers/md/persistent-data/dm-btree-remove.c | 2 ++
> drivers/md/persistent-data/dm-btree.c | 1 +
> drivers/md/persistent-data/dm-space-map-disk.c | 1 +
> 4 files changed, 5 insertions(+), 0 deletions(-)

This one is a bit more interesting. The above files (and actually their
parent dir) doesn't exist yet in master/HEAD. So I can't patch them
yet. And the MD maintainers can't patch in export.h usage, since they
won't have such a header file.

If you didn't want to temporarily carry it, I can think of two things:
I suppose, since the one single commit that creates export.h is totally
standalone, and harmless/inert in itself, we could perhaps get it pulled
independently if it made life easier for others to align to the right
usage? Or they can just patch in module.h usage and we can downgrade
them to export.h usage shortly thereafter.

Paul.

>
> diff --git a/drivers/md/persistent-data/dm-block-manager.c b/drivers/md/persistent-data/dm-block-manager.c
> index 4ec480c..7b8e84c 100644
> --- a/drivers/md/persistent-data/dm-block-manager.c
> +++ b/drivers/md/persistent-data/dm-block-manager.c
> @@ -9,6 +9,7 @@
> #include
> #include
> #include
> +#include
>
> #define DM_MSG_PREFIX "block manager"
>
> diff --git a/drivers/md/persistent-data/dm-btree-remove.c b/drivers/md/persistent-data/dm-btree-remove.c
> index 72c9705..e7071f6 100644
> --- a/drivers/md/persistent-data/dm-btree-remove.c
> +++ b/drivers/md/persistent-data/dm-btree-remove.c
> @@ -8,6 +8,8 @@
> #include "dm-btree-internal.h"
> #include "dm-transaction-manager.h"
>
> +#include
> +
> /*
> * Removing an entry from a btree
> * ==============================
> diff --git a/drivers/md/persistent-data/dm-btree.c b/drivers/md/persistent-data/dm-btree.c
> index 55b8bf3..7cad5e8 100644
> --- a/drivers/md/persistent-data/dm-btree.c
> +++ b/drivers/md/persistent-data/dm-btree.c
> @@ -9,6 +9,7 @@
> #include "dm-transaction-manager.h"
>
> #include
> +#include
>
> #define DM_MSG_PREFIX "btree"
>
> diff --git a/drivers/md/persistent-data/dm-space-map-disk.c b/drivers/md/persistent-data/dm-space-map-disk.c
> index de31096..26e6e19 100644
> --- a/drivers/md/persistent-data/dm-space-map-disk.c
> +++ b/drivers/md/persistent-data/dm-space-map-disk.c
> @@ -13,6 +13,7 @@
> #include
> #include
> #include
> +#include
>
> #define DM_MSG_PREFIX "space map disk"
>
> --
> 1.7.5.4
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/

Re: linux-next: build warnings after merge of the moduleh tree

am 01.08.2011 02:35:37 von Stephen Rothwell

--Signature=_Mon__1_Aug_2011_10_35_37_+1000_JBJtInSUvgF70A6m
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, 31 Jul 2011 04:24:05 -0400 Paul Gortmaker ..com> wrote:
>
> [linux-next: build warnings after merge of the moduleh tree] On 29/07/201=
1 (Fri 15:25) Stephen Rothwell wrote:
>=20
> > Hi Paul,
> >=20
> > After merging the moduleh tree, today's linux-next build (x86_64
> > allmodconfig) produced these warnings:
> >=20
> > drivers/md/persistent-data/dm-block-manager.c:103:1: warning: type defa=
ults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> [...]
> > drivers/md/persistent-data/dm-space-map-disk.c:634:1: warning: type def=
aults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> [...]
> > drivers/md/persistent-data/dm-btree.c:146:1: warning: type defaults to =
'int' in declaration of 'EXPORT_SYMBOL_GPL'
> [...]
> > drivers/md/persistent-data/dm-btree-remove.c:569:1: warning: type defau=
lts to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> >=20
> > I have added the following patch for today:
> >=20
> > From: Stephen Rothwell
> > Date: Fri, 29 Jul 2011 15:16:04 +1000
> > Subject: [PATCH] include export.h to use EXPORT_SYMBOL
> >=20
> > Signed-off-by: Stephen Rothwell
> > ---
> > drivers/md/persistent-data/dm-block-manager.c | 1 +
> > drivers/md/persistent-data/dm-btree-remove.c | 2 ++
> > drivers/md/persistent-data/dm-btree.c | 1 +
> > drivers/md/persistent-data/dm-space-map-disk.c | 1 +
> > 4 files changed, 5 insertions(+), 0 deletions(-)
>=20
> This one is a bit more interesting. The above files (and actually their
> parent dir) doesn't exist yet in master/HEAD. So I can't patch them
> yet. And the MD maintainers can't patch in export.h usage, since they
> won't have such a header file.
>=20
> If you didn't want to temporarily carry it, I can think of two things:
> I suppose, since the one single commit that creates export.h is totally
> standalone, and harmless/inert in itself, we could perhaps get it pulled
> independently if it made life easier for others to align to the right
> usage? Or they can just patch in module.h usage and we can downgrade
> them to export.h usage shortly thereafter.

I will carry it for now (as a merge fixup on the moduleh tree. If the
export.h split goes to Linus, then Neil can apply it to his tree, or
Linus can apply it as a merge fixup ehen he merges the latter of the two
trees (as long as someone remember to tell him).

--=20
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

--Signature=_Mon__1_Aug_2011_10_35_37_+1000_JBJtInSUvgF70A6m
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQEcBAEBAgAGBQJONfTZAAoJEDMEi1NhKgbsWrkIAIUOb1KB4E8OERWU6sQy Kqed
5sRUXyDSq5/c5kkyMy5KTXHJ+vUURnZJjQqzuCYm6svP4ecnRWa2Xx3NyPFv Qcd3
fYwv9sL1A0kLUtK7MBMmsMMqHOHe7inEI0AhSjMm4BXFGWfDgWwGFF/uTGFf ZjLb
pVSZFBR9GS5ttuQD4ac+ns8byP6AWJAGWYD/srUCF7+Z+vESkhi8JqDQv6HB K1ZQ
tKw8AUGKBkeEQIl8J3KgayfO8rhapEUqhYZbAtBjH8zd0Re2hK6VdUPWBume A8P3
ZE9invdNm3deCSda6AIxkIq0r0Cd2PKbFHLfELqfm0U3e8WzghYsUZoFBUII c9w=
=f/IF
-----END PGP SIGNATURE-----

--Signature=_Mon__1_Aug_2011_10_35_37_+1000_JBJtInSUvgF70A6m --
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html