[PATCH] util: fix seg-fault when trying to kill-subarray in anon-existing container

open_subarray returns valid fd to a container. In case of error shall return
negative value.

Signed-off-by: Marcin Labun
---
util.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/util.c b/util.c
index ce03239..1680d6b 100644
--- a/util.c
+++ b/util.c
@@ -1370,7 +1370,7 @@ int open_subarray(char *dev, char *subarray, struct supertype *st, int quiet)
if (!quiet)
fprintf(stderr, Name ": Couldn't open %s, aborting\n",
dev);
- return 2;
+ return -2;
}

st->devnum = fd2devnum(fd);
--
1.6.4.2

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] util: fix seg-fault when trying to kill-subarray in anon-existing container

On Mon, Sep 5, 2011 at 7:17 AM, Labun, Marcin wrote:
> open_subarray returns valid fd to a container. In case of error shall return
> negative value.
>
> Signed-off-by: Marcin Labun

Collides with the patch Anna submitted a month ago [1]. Just ping the
old thread.

--
Dan

[1]: http://marc.info/?l=linux-raid&m=131221282424569&w=2
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] util: fix seg-fault when trying to kill-subarray in anon-existing container

On Tue, 6 Sep 2011 14:46:36 -0700 Dan Williams
wrote:

> On Mon, Sep 5, 2011 at 7:17 AM, Labun, Marcin wrote:
> > open_subarray returns valid fd to a container. In case of error shall return
> > negative value.
> >
> > Signed-off-by: Marcin Labun
>
> Collides with the patch Anna submitted a month ago [1]. Just ping the
> old thread.
>
> --
> Dan
>
> [1]: http://marc.info/?l=linux-raid&m=131221282424569&w=2


Thanks for the ping - applied (but you know that...)

NB
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html