[PATCH] DBD-mysql PERL_NO_GET

[PATCH] DBD-mysql PERL_NO_GET_CONTEXT

am 03.03.2004 13:10:59 von beau

Hello -

I have patched DBD-mysql to use PERL_NO_GET_CONTEXT
(refer to perldoc perlguts).

The patch is at:

Test results and supporting documentation is at:

This patch, since it runs in a different DBI interface -
mandated by the PERL_NO_GET_CONTEXT conversion -
will NOT be implemented until the DBV v2 interface is released
(currently being discussed on ).

If you want to test/install this patch:

Apply the DBI patch found at:
, with docs at
.

This patch may be applied to the current public DBI
release (1.41) or the DBI svn development source. Test and
install.

WARNING: any other DBDs installed that use XS code (that is, are not
pure-perl) will no longer work after this patch
is installed because of the new/different DBI interface.

Apply/Test/Install this patch against DBD-mysql-9.2003.

I hope this patch will be of use when Tim releases DBI v2.

Aloha => Beau;

--
MySQL Perl Mailing List
For list archives: http://lists.mysql.com/perl
To unsubscribe: http://lists.mysql.com/perl?unsub=gcdmp-msql-mysql-modules@m .gmane.org

Re: [PATCH] DBD-mysql PERL_NO_GET_CONTEXT

am 04.03.2004 05:08:26 von Rudy Lippan

On Wed, 3 Mar 2004, Beau E. Cox wrote:

> The patch is at:
>
>
>

So basically you are just adding the pTHX_ macro as the arg to all
function calls which obviates the need for the dTHR stuff, right? So then
Should the dTHR be removed from dbd_db_disconnect, & dbd_st_finish?

> This patch, since it runs in a different DBI interface -
> mandated by the PERL_NO_GET_CONTEXT conversion -
> will NOT be implemented until the DBV v2 interface is released
> (currently being discussed on ).
>

Would it be possible for you to modify your patch so that the code can be
used under both the regular DBI and your patched DBI depending on which
one it is compiled against? If so I will make it part of DBD::mysql
(assuming that DBI itself will be going this way).

> If you want to test/install this patch:
>
> Apply the DBI patch found at:
> , with docs at
> .
>
> This patch may be applied to the current public DBI
> release (1.41) or the DBI svn development source. Test and
> install.
>
> WARNING: any other DBDs installed that use XS code (that is, are not
> pure-perl) will no longer work after this patch
> is installed because of the new/different DBI interface.
>
> Apply/Test/Install this patch against DBD-mysql-9.2003.
>

I am not doing much work on the 2.9x branch at this point. The only thing
that I expect to do is bug fixes. All of the new development is being
done on the Dev-3_0 branch.

If you wish to take a look at the development code it can be found here:

cvs -d :pserver:anonymous@cvs.perl.org:2401/cvs/public co -r Dev-3_0 modules/DBD-mysql

Rudy

--
MySQL Perl Mailing List
For list archives: http://lists.mysql.com/perl
To unsubscribe: http://lists.mysql.com/perl?unsub=gcdmp-msql-mysql-modules@m .gmane.org

Re: [PATCH] DBD-mysql PERL_NO_GET_CONTEXT

am 04.03.2004 05:08:26 von Rudy Lippan

Re: [PATCH] DBD-mysql PERL_NO_GET_CONTEXT

am 04.03.2004 05:25:30 von beau

On Wednesday 03 March 2004 06:08 pm, Rudy Lippan wrote:
> On Wed, 3 Mar 2004, Beau E. Cox wrote:
> > The patch is at:
> >
> >
>
> So basically you are just adding the pTHX_ macro as the arg to all
> function calls which obviates the need for the dTHR stuff, right? So then
> Should the dTHR be removed from dbd_db_disconnect, & dbd_st_finish?

Yep, I missed them (execute too!).

>
> > This patch, since it runs in a different DBI interface -
> > mandated by the PERL_NO_GET_CONTEXT conversion -
> > will NOT be implemented until the DBV v2 interface is released
> > (currently being discussed on ).
>
> Would it be possible for you to modify your patch so that the code can be
> used under both the regular DBI and your patched DBI depending on which
> one it is compiled against? If so I will make it part of DBD::mysql
> (assuming that DBI itself will be going this way).

Good question - I'll look into it and get back to you.
Tim - on the dbi-dev list - has said that PERL_NO_GET_CONTEXT will
be a part of DBI's future.

>
> > If you want to test/install this patch:
> >
> > Apply the DBI patch found at:
> > , with docs at
> > .
> >
> > This patch may be applied to the current public DBI
> > release (1.41) or the DBI svn development source. Test and
> > install.
> >
> > WARNING: any other DBDs installed that use XS code (that is, are not
> > pure-perl) will no longer work after this patch
> > is installed because of the new/different DBI interface.
> >
> > Apply/Test/Install this patch against DBD-mysql-9.2003.
>
> I am not doing much work on the 2.9x branch at this point. The only thing
> that I expect to do is bug fixes. All of the new development is being
> done on the Dev-3_0 branch.
>
> If you wish to take a look at the development code it can be found here:
>
> cvs -d :pserver:anonymous@cvs.perl.org:2401/cvs/public co -r Dev-3_0
> modules/DBD-mysql

Thanks, Rudy. I'll work with that source.

>
>
> Rudy

Aloha => Beau;

--
MySQL Perl Mailing List
For list archives: http://lists.mysql.com/perl
To unsubscribe: http://lists.mysql.com/perl?unsub=gcdmp-msql-mysql-modules@m .gmane.org

Re: [PATCH] DBD-mysql PERL_NO_GET_CONTEXT

am 04.03.2004 05:25:30 von beau